Issues reported by PHPStan

Issue created by @bluegeek9
First commit to issue fork.
Merge request !5Fixed-issues-reported-y-phpstan-3398235 → (Open) created by shalini_jha
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
4 pass, 1 fail
Status changed to Needs review over 1 year ago11:52am 2 November 2023
Comment over 1 year ago →
🇮🇳India shalini_jha
hi @bluegeek9
Added MR for the fixes.
Thanks
Pipeline finished with Failed
over 1 year ago
Total: 137s
#43309
Status changed to Needs work over 1 year ago1:00pm 2 November 2023
Comment over 1 year ago →
🇺🇸United States bluegeek9
The tests fail in your pull request. Use of '// @phpstan-ignore-next-line' is unacceptable.
Comment over 1 year ago →
🇮🇳India ashutosh ahirwal India
Ashutosh Ahirwal → made their first commit to this issue’s fork.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
4 pass, 1 fail
Status changed to Needs review over 1 year ago12:32pm 4 January 2024
Comment over 1 year ago →
🇮🇳India ashutosh ahirwal India
Updated MR5.
Please review it.
Pipeline finished with Success
over 1 year ago
Total: 149s
#71522
Status changed to RTBC 9 months ago3:24am 14 August 2024

Hi @Ashutosh Ahirwal,

The update you made on MR5 can be applied successfully and confirmed errors were not reported.

views_date_format_sql git:(8.x-3.x) curl https://git.drupalcode.org/project/views_date_format_sql/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5399    0  5399    0     0  17976      0 --:--:-- --:--:-- --:--:-- 18553
patching file src/Plugin/views/argument/ViewsDateFormatSqlArgument.php
patching file src/Plugin/views/field/ViewsDateFormatSqlField.php
➜  views_date_format_sql git:(8.x-3.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_date_format_sql
➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake

Status changed to Needs work 9 months ago2:29pm 19 August 2024
Comment 9 months ago →
🇺🇸United States bluegeek9
https://git.drupalcode.org/issue/views_date_format_sql-3398235/-/jobs/57...

phpstan is not passing.
Comment 5 months ago →
🇺🇸United States bluegeek9
bluegeek9 → changed the visibility of the branch 3398235-issues-reported-by to hidden.
Assigned to bluegeek9
Status changed to Active 5 months ago7:04pm 23 November 2024
Comment 5 months ago →
🇺🇸United States bluegeek9
Comment 5 months ago →
🇺🇸United States bluegeek9
Merge request !12Issue #3398235 by bluegeek9: Issues reported by phpcs → (Merged) created by bluegeek9
Pipeline finished with Skipped
5 months ago
#348028
Comment 5 months ago →
System Message

bluegeek9 → committed 3918def6 on 8.x-3.x
Issue #3398235 by bluegeek9: Issues reported by phpcs
Comment 5 months ago →
🇺🇸United States bluegeek9
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!12Issues reported by PHPStan
Merged

!5Issues reported by PHPStan
Open

Comments & Activities

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!12Issues reported by PHPStanMerged

!5Issues reported by PHPStanOpen

Comments & Activities

!12Issues reported by PHPStan
Merged

!5Issues reported by PHPStan
Open