The mime type guesser service is changed for d10

It would be best to keep this backwards compatible. I'll update the MR.

There is no need to keep it backwards compatible. The 3.x branch only support Drupal 10 (as mentioned in the issue summary) ✌️🤓

My bad for not reading the issue summary, I fixed it.

Very nice!

Would be useful to write a test for this as well maybe? Are you able to suggest something there? Otherwise I will just leave it at needs review for now, and hope someone else can test and verify the fix?

I'm not really an expert on tests, so I'll pass. I'm not sure this really needs a test though, what exactly would you even test?

Added a test and uploaded the test only patch here, so we can see it tests what its supposed to test

Hm, guess we won't see the result of those before either 📌 PHPCS issues for 3.x Needs review or 📌 use gitlab ci Needs review (or both) is merged.

Thanks for the fix @eiriksm.

Uploading https://git.drupalcode.org/project/sparkpost/-/merge_requests/8/diffs back as a patch to use for a composer based project.

Applying this patch on a site that utilizes PHP 8.3 fixes the PHP error related to guess changing but results in the following error in watchdog:

No php-http message factories found. Note that the php-http message factories are deprecated in favor of the PSR-17 message factories. To use the legacy Guzzle, Diactoros or Slim Framework factories of php-http, install php-http/message and php-http/message-factory and the chosen message implementation.