- Issue created by @eiriksm
- Open on Drupal.org āCore: 10.2.1 + Environment: PHP 7.4 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 3:36pm 17 February 2024 - š³š“Norway eiriksm Norway
Example of failing test run: https://www.drupal.org/pift-ci-job/2856321 ā
- last update
10 months ago 4 pass - last update
7 months ago 4 pass - Status changed to Needs work
4 months ago 1:55pm 11 August 2024 - šµšPhilippines clarkssquared
Hi
I applied the MR !11, the patch didnt apply properly and there are many PHPCS issues.
ā sparkpost git:(8.x-2.x) curl https://git.drupalcode.org/project/sparkpost/-/merge_requests/11.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2859 0 2859 0 0 5337 0 --:--:-- --:--:-- --:--:-- 5487 patching file 'src/ClientService.php' 1 out of 1 hunks failed--saving rejects to 'src/ClientService.php.rej' patching file 'src/Form/TestMailForm.php' patching file 'src/Plugin/Mail/SparkpostMail.php' ā sparkpost git:(8.x-2.x) ā .. ā drupal_local git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml sparkpost FILE: /Users/clarksubing-subing/Projects/d10/drupal_local/sparkpost/src/Form/SettingsForm.php --------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES --------------------------------------------------------------------------------------------- 54 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 83 | WARNING | #options values usually have to run through t() for translation 84 | WARNING | #options values usually have to run through t() for translation --------------------------------------------------------------------------------------------- FILE: /Users/clarksubing-subing/Projects/d10/drupal_local/sparkpost/src/Form/TestMailForm.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 129 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- FILE: /Users/clarksubing-subing/Projects/d10/drupal_local/sparkpost/src/ClientService.php ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Http\Adapter\Guzzle6\Client. 70 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/clarksubing-subing/Projects/d10/drupal_local/sparkpost/src/MessageWrapper.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------- 126 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 135 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- Time: 555ms; Memory: 12MB ā drupal_local git:(main) ā
-
eiriksm ā
committed af9e0e00 on 3.x
Issue #3422111 by eiriksm: PHPCS issues for 3.x
-
eiriksm ā
committed af9e0e00 on 3.x
- Status changed to Fixed
about 1 month ago 1:52pm 11 November 2024 Automatically closed - issue fixed for 2 weeks with no activity.