Notice: Only variable references should be returned by reference

HI @tkiehne
I have fixed the issue & added patch file, please review.

The last submitted patch, 4: only-variable-references-should-be-fixes-3397767.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

reupload the patch file.

@tkiehne, i have fixed the issue, please kindly review the MR.

The last submitted patch, 7: only-variable-references-should-be-fixes-3397767.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

above patch failed due to text not found, but i have fixed the mentioned issue.

I've tested the patch in #7, and while it does suppress the notice, it appears to cause other issues. Namely, I had it set so that admins can optionally create a password when creating a user which should allow the password to be optional on the user add form. With this patch the password field is now required and can't be left empty, so it would seem that the function does need to pass the password field to the form alter by reference, we just need it to not pass a NULL literal in the case when the form item is not found.

The return by reference is very important to that function. Simply removing it just breaks the functionality as stated by @tkiehne.

Reverted the changes and fixed the function so that it's always returning a reference.

Thank you for the bug report.

NB: Please do not use the patch on #7 - it includes some schema changes, and breaks the functionality of the module.

Screwed up credit sorry. I should just merge these things manually in git.

Could we have a minor release for this?

I filed 🌱 Genpass 2.0.2 release Active to discuss that.

Automatically closed - issue fixed for 2 weeks with no activity.