Genpass 2.0.2 release

Open on Drupal.org →

Created on 7 November 2023, over 1 year ago

Updated 8 November 2023, over 1 year ago

Looking at the commit log there's quite a few changes since 2.0.1 on October 20th, 2023.

The fix in 🐛 Notice: Only variable references should be returned by reference Fixed seems like it might justify a new release.

Is the codebase in a state where we can do a new release?

Here's the list of commits:

ca45f65 (HEAD -> 2.0.x, origin/2.0.x) Disable all OPT_IN_ in gitlab-ci
065269e Disable OPT_IN_TEST_PREVIOUS_MINOR
9d8b4db Use multi-line array format for service arguments.
1850d10 Trial using gitlab-ci using DA template.
2a4ede1 Remove translations from tests.
ac746b1 Remove now deprecated hook_uninstall.
a541ccf Update to fix any existing action config missing dependency on genpass.
9bf492b Fix update 8002 so it results in config dependencies for genpass action.
515eeb7 Avoid unwanted phpcs warnings.
2022f7e Add enforced dependency to optional action config.
62a048f Issue #3398562 by ELC: Remove extraneous Yaml quoting of strings.
4d51705 Resolve #3397767 "Notice only variable"
61a5891 by ELC: Update line numbers on code links.
a8a85f9 Trivial commit to confirm auth is working
78709a8 by ELC: Move the static cache into form_alter because it's faster.

🌱 Plan

Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States greggles Denver, Colorado, USA

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @greggles
Comment over 1 year ago →
🇺🇸United States greggles Denver, Colorado, USA
Comment over 1 year ago →
🇺🇸United States greggles Denver, Colorado, USA
I reviewed those commits and they seem to mostly be for Gitlab CI preparation.

I filed an issue to track that work at 📌 Switch to DrupalCI as test runner Active .

It looks quite close!
Assigned to elc
Comment over 1 year ago →
🇦🇺Australia elc
Yep, that was the plan. Just quickly setup gitlab-ci and then do a 2.0.2 release. A small screaming thing pulled me away for the night.
Status changed to Needs review over 1 year ago4:17am 8 November 2023
Comment over 1 year ago →
🇦🇺Australia elc
This is ready to go.

Release note:

This release fixes an annoying php warning, a minor performance boost on form_alter, and switches 2.0.x branch over to Gitlab CI.

Bugs

🐛 Notice: Only variable references should be returned by reference Fixed

Ensure installed action config is removed on uninstall 2022f7e3, 9bf492b1, a541ccfd

Tasks

📌 YAML quoting in files is mostly unnecessary Fixed

Performance boost in form_alter by moving static cache 78709a8d

Remove translations from tests 2a4ede1b

Use Gitlab CI for 2.0.x branch

Minor code cleanups as a result, and general code tidy

Fix up links for code references 61a58910

Greggles made sure he could commit a8a85f9f

All changes since 2.0.1
https://git.drupalcode.org/project/genpass/-/commits/2.0.2?ref_type=tags

// end release note
Status changed to Fixed over 1 year ago5:20am 8 November 2023
Comment over 1 year ago →
🇦🇺Australia elc
Since everyone's asleep and this is ready to go and passing tests, let's see if it flies.
Comment over 1 year ago →
🇺🇸United States greggles Denver, Colorado, USA
Thanks, ELC!
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024