- Issue created by @ultimike
- First commit to issue fork.
- 🇲🇦Morocco h_kac
I updated services, form Class and the controller to use Dependency Injection.
- Status changed to Needs review
about 1 year ago 1:29pm 29 October 2023 - 🇺🇸United States ultimike Florida, USA
@h_kac - looks good to me - did you manually run the tests? Are they still working?
Maybe create a new issue in this queue for utilizing Gitlab CI tests... (see https://www.drupal.org/project/smart_trim/issues/3366047 📌 Utilize new GitLab CI features Fixed for an example)
If tests are passing, then I'm cool setting this to RTBC.
-mike
- 🇲🇦Morocco h_kac
@mike yes I run the tests using phpunit and all is Green.
- Status changed to RTBC
about 1 year ago 5:51pm 3 November 2023 - 🇺🇸United States ultimike Florida, USA
Great - since all tests are passing, I'm setting this to RTBC.
-mike
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 7.4 & MySQL 5.7 updated depslast update
about 1 year ago Waiting for branch to pass - @vensires opened merge request.
- First commit to issue fork.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 7.4 & MySQL 5.7 updated depslast update
about 1 year ago Waiting for branch to pass -
vensires →
committed b6c7bd99 on 2.x
Issue #3397288 by ultimike, h_kac: Properly inject all dependencies in 2...
-
vensires →
committed b6c7bd99 on 2.x
- Status changed to Fixed
about 1 year ago 10:27pm 13 November 2023 - 🇬🇷Greece vensires
Code pushed to latest 2.x version of the module. Thanks to everyone involved in the process!
Automatically closed - issue fixed for 2 weeks with no activity.