Automated Drupal 10 compatibility fixes

Created on 16 August 2022, almost 2 years ago
Updated 29 March 2024, 3 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects β†’

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot β†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot β†’ .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot β†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue β†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue β†’ using the component β€œBot: Drupal Rector”.

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡«πŸ‡·France FMB PerpinyΓ , Catalonia, EU

    Hi, any plan for a D10 version? This could be a blocker for many projects. Thanks!

  • First commit to issue fork.
  • πŸ‡¨πŸ‡¦Canada phjou Vancouver/Paris πŸ‡¨πŸ‡¦ πŸ‡ͺπŸ‡Ί

    It is actually a blocker for us, we have to fork the project until this is fixed.

  • πŸ‡¨πŸ‡¦Canada phjou Vancouver/Paris πŸ‡¨πŸ‡¦ πŸ‡ͺπŸ‡Ί

    Ok I just defined another repository before the drupal one to override with the repository that contains the Drupal 10 support until that issue is fixed.

            {
                "type": "vcs",
                "url": "https://git.drupalcode.org/issue/auto_login_url-3303974.git"
            },
    

    "drupal/auto_login_url": "2.x-dev",

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.6
    last update 12 months ago
    Composer require failure
  • πŸ‡¨πŸ‡¦Canada Nathan Tsai

    An alternative workaround:

    1. Require composer require mglaman/composer-drupal-lenient:^1.0

    2. Patch the module

      "extra": {
          "patches": {
                "drupal/auto_login_url": {
                    "#3303974: Support Drupal 10": "https://www.drupal.org/files/issues/2022-08-16/auto_login_url.2.x-dev.rector.patch"
                }
          }
      }
    

    3. Allow drupal/auto_login_url to be installed even if the Drupal platform requirement is not met.

      "extra": {
            "drupal-lenient": {
                "allowed-list": [
                    "drupal/token",
                    "drupal/superfish",
                    "drupal/redirect_anonymous_users",
                    "drupal/body_scroll_lock",
                    "drupal/auto_login_url"
                ]
            }
      }
    <code>
    
    4. Require <code>composer require drupal/auto_login_url
  • First commit to issue fork.
  • Status changed to RTBC 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States ultimike Florida, USA

    I've added the patch changes to the issue fork and have created a MR.

    I've tested the changes and things appear to be working.

    For those new to this module, be sure to see https://www.drupal.org/project/auto_login_url/issues/2878078#comment-152... ✨ Delete "use auto login url" permission from auto_login_url.permissions.yml Needs work for a quick explanation of configuration permissions for this module.

    I also think there are some opportunities for contribution for coders - specifically:

    • Dependency injection of services into the various classes in this module.
    • Convert database queries into entity queries.
    • Improved docblock comments.

    If anyone is interested, a new issue should be opened for each and worked on in separate issue forks.

    -mike

  • Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 7.4 & MySQL 5.7 updated deps
    last update 8 months ago
    Waiting for branch to pass
  • @ultimike opened merge request.
  • πŸ‡ΊπŸ‡ΈUnited States ultimike Florida, USA

    Added new issue for updating dependency injection stuff: πŸ“Œ Properly inject all dependencies in 2.x branch Active

    -mike

  • First commit to issue fork.
  • Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 7.4 & MySQL 5.7 updated deps
    last update 8 months ago
    Waiting for branch to pass
  • Status changed to Fixed 8 months ago
  • πŸ‡¬πŸ‡·Greece vensires

    Fixed in 2.x. A great thank you to everyone who spent time on this.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 6 months ago
  • πŸ‡¬πŸ‡§United Kingdom james.williams

    When could we expect an official release that would be compatible with Drupal 10 please? This is one of about 5 contrib projects that remain without compatible releases on a site I'm in the process of upgrading.

  • πŸ‡ΊπŸ‡ΈUnited States ultimike Florida, USA

    Not sure yet - I was just made a co-maintainer of this module and am working to clean up the code base a bit...

    -mike

  • πŸ‡«πŸ‡·France Nicolas Bouteille

    Starting my D10 upgrade right now, and using this module. Any updates?

  • πŸ‡¬πŸ‡·Greece vensires

    I have just created release 2.0.0-alpha3 β†’ . Please check and create any new issues required.

    Plus, I think that if no major issues exist, we can set the next release as stable finally.

  • πŸ‡«πŸ‡·France Nicolas Bouteille

    thanks a lot! will get back to you when I have done so.

  • πŸ‡«πŸ‡·France Nicolas Bouteille

    it works thanks :)

  • πŸ‡¬πŸ‡·Greece vensires

    Thanks for the information!
    I will update the description of the module too!

Production build 0.69.0 2024