CKEditor5 field not getting disabled on locked form

Here's a version of the patch for CKEditor 5, and the relevant documentation:

- https://ckeditor.com/docs/ckeditor5/latest/features/read-only.html
- https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editor...

I tested it out and it works. Patch seems like a simple enough edition.

There was already an open issue for this, but I've closed it since it did not have a patch and this issue does.

✨ Compatibility with CKEditor5 (and take advantage of the CKE5 Restricted Editing Mode) Closed: duplicate

Please consider searching for existing issues before creating new ones, thank you.

IICR this will work for CKEditor4, but not CKEditor5 introduced in Drupal 9.3 and default in D10. Shouldn't stop this to be RTBC, but we might want to check with CK5 and create a separate issue.

@penyaskito have you tested the latest MR to be sure that it does not work? Because in my testing this module works as is for CKE4, but not CKE5, and while I haven't tested the MR here (yet), my assumption is that it makes this work for CKE5.

There are two patches in this issue:
- #2 is for when you're using CKEditor 4.
- #4 is for when you're using CKEditor 5.

And so...
- If content_lock decides to go with CKEditor 4, then patch #2 is the one to merge.
- If content_lock decides to go with CKEditor 5, then patch #4 is the one to merge.
- If content_lock decides to support both versions, a new patch with both changes would probably be needed.

This will need a maintainer's input.

Tried the MR and patch #4 but neither seem to work with ckeditor5 fields.

📌 Disable all input elements with JS lock Needs work may be related.

Actually doing another test on a different sites #4 worked.

So I did a fresh install and #4 worked. Updated the MR

Actually sorry for the noise. Does 🐛 Ckeditor field not getting disabled on locked form RTBC address the issue? From my testing it does but maybe someone else can confirm and maintainer move over credit.

@smustgrave in your last comment you linked this issue, did you mean to link a different one?

In any case, my feeling is that since CKE5 provides an actual API for disabling the editor, maybe using that here is a more robust and future proof solution?

Sorry 📌 Disable all input elements with JS lock Needs work

Okay I was able to replicate this issue when using "Lock form using JS."

The MR does fix the problem. But some reason why I try to extend testContentLockNode by checking the js form. All the assertion messages fail.

Figured out why, this setting has to be in a javascript test duh.

Great to see this get committed.

In testing, I note that this only works with CKE5 when the JS locking feature is enabled. I wonder if that's something which needs to be addressed, or if that's more of a "by design" and it just needs to be documented. My worry is that because CKE5 is the default editor in Drupal, if that option isn't on by default then it could result in people thinking that this module still doesn't work with CKE5.

@Aaron From what I tested, if you are not using JS locking, it just works (TM). If I'm right, it's because of the $form['#disabled'] = TRUE; ¡n content_lock_form_alter

@penyaskito are you testing with CKEditor5? Because yes CKEditor4 is disabled fine, this issue is specifically about CKEditor5 and here we used the CKEditor5 API to disable the editor, but from my testing that only seems to work if JS Lock is turned on.

Yes. No js locks, ckeditor5, even custom plugin buttons are disabled (but one, but that's probably an issue on our custom plugin).
The styling could be different for having some visual indicator, but I cannot edit that text.

Automatically closed - issue fixed for 2 weeks with no activity.