- Issue created by @nicolasgraph
- Merge request !323Introduces dependencies injection in GinNavigation.php β (Open) created by nicolasgraph
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:49am 22 October 2023 - Status changed to Needs work
over 1 year ago 9:55am 22 October 2023 - π¨πSwitzerland saschaeggi Zurich
This MR has phpcs errors, see https://git.drupalcode.org/issue/gin-3395897/-/jobs/207682
So moving back to needs work π
- Status changed to Needs review
over 1 year ago 10:36am 22 October 2023 - Assigned to BenStallings
- Status changed to Needs work
5 days ago 4:24pm 5 May 2025 - πΊπΈUnited States BenStallings
I'm going to update this to the 4.0 branch.
- πΊπΈUnited States BenStallings
I rebased the branch on 4.x, but I don't seem to be able to change the target branch in the MR; it is still pointing to 3.x. I apologize and hope someone will be able to fix it!
- π«π·France nicolasgraph Strasbourg
nicolasgraph β changed the visibility of the branch 8.x-3.x to hidden.
- π«π·France nicolasgraph Strasbourg
nicolasgraph β changed the visibility of the branch 3395897-use-dependency-injection to active.
- π«π·France nicolasgraph Strasbourg
@benstallings, I changed the MR target branch but it seems there are some errors in the pipeline.
I let you check that and update the issue status once done. - πΊπΈUnited States BenStallings
@nicholasgraph, I'm not able to replicate the 500 error that gitlab's phpunit is experiencing. When I run phpunit locally, I get a different error about the database connection being refused. However, when I view my local environment in a browser, the patched gin theme works just fine (as does the database). So this may be out of my wheelhouse, I'm afraid.