- Issue created by @peter tรถrnstrand
- ๐ธ๐ชSweden peter tรถrnstrand
Adopting this change would require a change in the
core_version_requirement
.From:
core_version_requirement: ^8.7.7 || ^9 || ^10
To:core_version_requirement: ^9.2 || ^10
- ๐ฉ๐ชGermany geek-merlin Freiburg, Germany
Thanks for spotting this.
Does the patch fix the problem for you?
Yes, we can require ^9.2
Can you please push an MR with that patch AND the updated core_version_requirement?
And please, remove this unrelated change.
- /** @var \Drupal\Core\Field\WidgetInterface $widget */
- First commit to issue fork.
- last update
over 1 year ago 1 pass - @shiv_yadav opened merge request.
- Status changed to Needs review
over 1 year ago 10:06am 20 October 2023 - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia shiv_yadav
Hello geek-merlin, I have created MR with new changes.
Please review & retest it.
Thanks. - Status changed to Needs work
over 1 year ago 12:05pm 20 October 2023 - ๐ฉ๐ชGermany geek-merlin Freiburg, Germany
Good start.
But as i said in #5:And please, remove this unrelated change.
- /** @var \Drupal\Core\Field\WidgetInterface $widget */
Also we need someone to do a manual test and confirm this patch fixes the issue, i.e. makes this work on D10.
- last update
over 1 year ago 1 pass - Status changed to Needs review
over 1 year ago 12:32pm 20 October 2023 - ๐ฎ๐ณIndia shiv_yadav
hello geek-merlin,
- I have installed this module on D10 & fix unrelated change.
Thanks. - Status changed to Needs work
over 1 year ago 12:55pm 20 October 2023 - ๐ฉ๐ชGermany geek-merlin Freiburg, Germany
Testing means assuring (e.g. with a before / after screenshot) that the module does what it announces, i.e. hide the seconds part of a date field widget.
- Status changed to Closed: outdated
6 months ago 12:40pm 27 October 2024 - ๐ซ๐ทFrance mably
Seems to have been fixed by ๐ Doesn't hide seconds on Drupal 10 Fixed .