CKEditor 5 editing table with rowspans removes header property

I've had a look through upstream issues and I think https://github.com/ckeditor/ckeditor5/issues/14826 might be the same problem?

There's a pull request in there which is waiting for review, I'm not sure how well it would apply to Drupal though...

https://github.com/ckeditor/ckeditor5/issues/14826 indeed seems right!

Can you please provide sample markup of what you'd like CKEditor 5 be able to support? That way I could write test coverage to ensure that once this is fixed upstream, that we'd never regress against this in Drupal core 👍

Hey Wim,

Sounds good, here's some markup for the 'Table 1' example above.
<table><thead><tr><th>Header</th><th>Header</th><th>Header</th><th>Header</th></tr></thead><tbody><tr><th>Header</th><th>Header</th><td>Data</td><td>Data</td></tr><tr><th rowspan="2">Header</th><th>Header</th><td>Data</td><td>Data</td></tr><tr><th>Header</th><td>Data</td><td>Data</td></tr></tbody></table>

It might be a little tricky to test since the problem only manifests when the editor is activated. Expected result is that opening the content in edit mode and saving immediately would result in the same HTML; instead the markup is changed to:
<table><thead><tr><th>Header</th><th>Header</th><th>Header</th><th>Header</th></tr></thead><tbody><tr><th>Header</th><td>Header</td><td>Data</td><td>Data</td></tr><tr><th rowspan="2">Header</th><td>Header</td><td>Data</td><td>Data</td></tr><tr><td>Header</td><td>Data</td><td>Data</td></tr></tbody></table>
(second column has been converted from th to td)

Thank you! That's all I need :) Don't know when I'll get to writing this test coverage, but I will eventually.

(It actually won't be tricky; we have plenty of examples of FunctionalJavaScript tests for CKEditor 5 that perform the steps you describe. See CKEditor5Test for a bunch of examples — it could be a valuable learning experience for you on how to write a test like this: once you get the hang of it, it's a huge enabler! 😊)

Hello,

I think I get the same issue with differents steps to reproduce.

1. Create a 3x4 table
2. Merge the 2 last rows in the 1st column

3. Save the block, the layout is fine.

4. Edit the table again, the option is "Column header" is off again in the tooltips but stays active in front.

If I unmerge the last 2 rows from the 1st column, then the option keep is ON state in accordance to the front layout.

This involves dataloss so I would say critical bug.

Typo3 also reported this: https://forge.typo3.org/issues/105644

Ck5 Issues

1. https://github.com/ckeditor/ckeditor5/issues/14911
2. https://github.com/ckeditor/ckeditor5/issues/17962
3. https://github.com/ckeditor/ckeditor5/pull/17870

Compiled 44.3.0 , did not fix the problem, trying the master branch of ckeditor5 now.

With that said, Wordpress is using TinyMCE . There's tens of millions of TinyMCE success stories and it worked great in Drupal 7 also. I believe it's time to bring back TinyMCE!
Unbelievable situation!

head of master and that build didn't help. Back to major, not much we can do, it's upstream.

ok we did find a workaround for table mangling, we disabled the insertTable plugin.

ok so maybe this isn't so much upstream. What is this insertTable plugin? Is it pure ck5 or is it some sort of core add-on?

Removing the table widget will unfortunately not work for most people as that will also remove the ability to insert and edit tables (apart from with Source editing).

I've started using a patch that adds the code from the relevant upstream issue (https://github.com/ckeditor/ckeditor5/issues/14826) and it does seem to solve the problem. I won't add this in an MR as it is not a real solution and very much use-at-own-risk (real solution will be to direct some attention to the upstream issue and hope it gets resolved there).