- Issue created by @cedewey
- First commit to issue fork.
- last update
over 1 year ago 12 pass, 2 fail - @diwakar07 opened merge request.
- Assigned to diwakar07
- Status changed to Needs review
over 1 year ago 7:52am 26 October 2023 - 🇮🇳India diwakar07
Hi,
I have updated the Comment Notify interface page accordingly.
Please review. - Issue was unassigned.
- 🇺🇸United States greggles Denver, Colorado, USA
Thanks for this proposal, @cedewey and for making the fixes, @Diwakar07!
@cedewey are you able to review the proposed merge request?
- Status changed to RTBC
10 months ago 10:52am 12 June 2024 - Status changed to Needs work
4 months ago 4:35am 10 December 2024 - 🇹🇭Thailand AlfTheCat
Hi guys, thanks for the great work.
I ran into 3 issues after applying the patch (running Drupal 10.3.9):
1 - the new setting for "Default state for the notification selection box" is confusing because the help text: "Choose the default subscription mode if both subscriptions modes are enabled." implies that I should select 1 option yet there are checkboxes allowing me to select all or none of the states. I think that if the admin is prompted for a default state, there should be a required radio select widget that allows only one option.
2 - After I save the settings form I get a WSOD with error:
The website encountered an unexpected error. Try again later. InvalidArgumentException: The configuration property enable_default.watcher.1 doesn't exist. in Drupal\Core\Config\Schema\ArrayElement->get() (line 95 of core/lib/Drupal/Core/Config/Schema/ArrayElement.php).
3 - On the user account edit form, the text: "Check this box to receive email notifications for comments on your content (e.g. an article authored by you). You cannot disable notifications for individual threads." is confusing to end users because in my case they don't have the option to author articles. I think that in the help text it shouldn't be assumed site users are familiar with the article content type, and a more ambiguous text is perhaps better. I.e.: "Check this box to receive email notifications for comments on content you authored. You cannot disable notifications for individual threads."
Thanks and hope this helps.