Contrib.social

[CKE5] Get entity_embed working with CKE5

Open on Drupal.org →
Created on 17 October 2023, 8 months ago
Updated 18 October 2023, 8 months ago

Problem/Motivation

The entity_embed module is included with WxT, but it doesn't work with CKE5. I have three patches to add to WxT that I find myself adding to all projects now.

The main patch is for drupal/entity_embed, to get it working with D10/CKE5. It requires a patch for drupal/embed to work, also included here. I have been following the long thread for entity_embed (related issue) and so far the approach in #93 ✨ Drupal 10 & CKEditor 5 readiness Fixed seems to be the best.

Once the patches are applied, you can then see CKE5 plugin buttons when you edit your text formats. I have tested this with both blocks and nodes, with translations in English and French, and it works great!

🐛 Bug report
Status

Fixed

Version

5.0

Component

User interface

Created by

🇨🇦Canada smulvih2 Canada 🍁

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @smulvih2
  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇨🇦Canada smulvih2 Canada 🍁

    Also added a patch for drupal/entity_browser to fix a PHP error, as well as fix an existing patch to include the drupal/ at the beginning of the module's name.

  • Comment 8 months ago →
    System Message
  • Status changed to Fixed 8 months ago
  • Comment 8 months ago →
    🇨🇦Canada sylus

    Lets do this!

    I know you spent a lot of time getting this working, and I read over a bit of the issue you attached and the approach seems reasonable.

    Also the fact that we really need to support this as more and more people switch to CKEditor 5 and eventually I do want to remove CKEditor 4.

    Committed and attributed!

  • Comment 8 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024