- Issue created by @tedbow
- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Not currently mergeable. - @tedbow opened merge request.
- last update
about 1 year ago 770 pass - First commit to issue fork.
- last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass - last update
about 1 year ago 763 pass, 1 fail - last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass - last update
about 1 year ago 771 pass - last update
about 1 year ago 771 pass - last update
about 1 year ago 771 pass - last update
about 1 year ago 771 pass - last update
about 1 year ago 771 pass - last update
about 1 year ago 771 pass - last update
about 1 year ago 771 pass - last update
about 1 year ago 764 pass, 2 fail - last update
about 1 year ago 760 pass, 8 fail - Status changed to Needs work
about 1 year ago 5:55pm 18 October 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
I talked with @phenaproxima about this and I was wondering whether we could try to get tests only running on gitlabci and ask for a core exception to allow skipping our tests run in core drupalci. I thought this would be ok because our test would still run on gitlab ci.
but then I talked to @effulgentsia and he pointed out that some issue are done only via patch in core. In that case gitlab-ci would not run. So we might introduce regressions without knowing it until the gitlab pipelines ran on the branch after commit.
so that is probably not possible until core stops using the patch development workflow together. But effulgentsia thought we should check to see if there is timeframe. We might not have to wait for any infrastructure changes for that since there is limited number of Drupal 10 core committers and they could just agree to all stop using patches or always run a merge request before committing issues.
You could even imagine a core committer script
create-mr-from-patch [PATCH-URL] [ISSUE_NUM]
This situation is especially bad for this module
- We are trying to maintain a workflow where our core MR's made from conversion script
- By the nature of our build test they need the Composer templates that are in a core clone
- Test in contrib gitlab-ci does not use a core clone, drupalci does
- last update
about 1 year ago Composer require-dev failure - last update
about 1 year ago Composer require-dev failure - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - πΊπΈUnited States tedbow Ithaca, NY, USA
I am working on π Change core merge request converter to either produce the Package Manager only MR or with AutoUpdates Needs work and running into problems I think this issue could help with.
- Many times a lot of the problem of doing the core merge request conversion is actually that our test fail against 11.x.
- Right now I don't think we can test against 11.x in drupalci
- I don't think 2) is going to be fixed because Drupalci is going away
This effectively keeping the merge request anywhere up-to-date very hard because we can only test 11.x in core merge request
Right now it looks like the problems with gitlab tests in the current MR that @phenaproxima is working on are
- The build tests fail
- GitExcluderTest fails
- PHPCS fails
Here is what I propose we do.
- If possible in our
.gitlab-ci.yml
exclude the build tests from running. We are still running them in drupalci for now so we won't introduce any regresssions - Try to get GitExcluderTest passing on gitlabci if it is not hard. If it is hard introduce a temporary
skipOnGitlabCI()
function. and open up a follow-up to remove this for GitExcluderTest. Again this will still run on drupalci - Exclude the PHPCS on gitlabci but open up a follow to get this passing
- If possible have our gitlab CI run on against 10.1.x and 11.x. If not just run again 11.x
This obviously is not where we would like to be but will make sure we don't introduce any incompatibilities with 11.x
Also the core merge request the build tests will run in core clone which is what they are currently written assuming. So we could still work on the core merge request changes to core's own gitlabci.yml to get the core MR build tests passing even if they aren't passing yet in contrib module.
Basically lets get what we can passing now on gitlabci and commit that while continue to also run drupalci. Then lets try to get everything running on gitlabci
- last update
12 months ago 782 pass - last update
12 months ago Build Successful - πΊπΈUnited States tedbow Ithaca, NY, USA
unexpected test failures in the new more limited MR.
retesting existing MR to see if it has this new fails too - last update
12 months ago Build Successful - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
100% of test failures on GitLab CI are build tests.
Looks like π BuildTestBase makes assumptions it should not about the code layout Active needs to be fixed before they can pass.
Relevant Drupal Slack
#gitlab
thread: https://drupal.slack.com/archives/CGKLP028K/p1700658999366429 - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - πΊπΈUnited States tedbow Ithaca, NY, USA
I talked with @Wim Leers and @phenaproxima I have updated the summary plan. Basically we just use gitlab to test the version of the module that is converted for the core merge request in β¨ Add Alpha level Experimental Automatic Updates module Needs work
for we will use drupalci to test the contrib version
- last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 776 pass, 1 fail - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 771 pass, 4 fail - last update
12 months ago 783 pass - last update
12 months ago Custom Commands Failed - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 776 pass, 1 fail - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 776 pass, 1 fail - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - last update
12 months ago 783 pass - Status changed to RTBC
12 months ago 2:52pm 19 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Looks like it creates the codebase correct!
-
phenaproxima β
committed ee1286b9 on 3.0.x
Issue #3394413 by phenaproxima, tedbow: Enable GitLab CI, and use it to...
-
phenaproxima β
committed ee1286b9 on 3.0.x
- Status changed to Fixed
12 months ago 3:14pm 19 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.