Contrib.social

Change core merge request converter to either produce the Package Manager only MR or with AutoUpdates

Open on Drupal.org →
Created on 4 October 2023, 9 months ago
Updated 14 December 2023, 7 months ago

Problem/Motivation

📌 Update module's merge request process for current core HEAD Fixed fix the converter for 11.x on ✨ Add Alpha level Experimental Package Manager module Needs review

We need it to work with ✨ [PP-1] Add Alpha level Experimental Automatic Updates module Needs review so reviewers can see both in one 1 MR

Right now the conversion is being tested on 📌 [ignore] Test Package manager core merge Needs work on the 2977515-pm-core-mr-9-2023 branch.
It is passing except for some functional test because of a new core bug 🐛 Exceptions in batch no longer are shown on the page when Javascript is disabled Needs work in 11.x

Steps to reproduce

Proposed resolution

Get the core merge request passing

It is combo of

  1. fixes for core 11.x compatibility, the module itself would fail if we could test again 11.x now
  2. Fixes to make Auto-Updates to work as core module

All functional tests will not pass yet because of 🐛 Exceptions in batch no longer are shown on the page when Javascript is disabled Needs work but we probably shouldn't wait on that

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs work

Version

3.0

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tedbow
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    Custom Commands Failed
  • @tedbow opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    Custom Commands Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    37:22
    36:31
    Running
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    35:31
    34:31
    Running
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    770 pass, 2 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    770 pass, 2 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    777 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    777 pass
  • Assigned to phenaproxima
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA
  • Comment 9 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    777 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    777 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    777 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    770 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    770 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    770 pass
  • Issue was unassigned.
  • Status changed to RTBC 9 months ago
  • Comment 9 months ago →
    🇺🇸United States phenaproxima Massachusetts

    If this passes, I think it looks good. No objections. We'll need to mention in the release notes that you have to run the command as php vendor/bin/auto-update.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    770 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    770 pass
  • Comment 9 months ago →
    System Message
    • tedbow → committed e5f573b9 on 3.0.x 
      Issue #3391715: Change core merge request converter to either produce...
  • Status changed to Fixed 9 months ago
  • Comment 9 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA

    @phenaproxima thanks for the reviews. I updated the change record https://www.drupal.org/node/3393723 →

  • Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    Not currently mergeable.
  • @tedbow opened merge request.
  • Assigned to tedbow
  • Status changed to Active 8 months ago
  • Comment 8 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA

    Creating a new MR and re-opening the issue

    Now that we have a fix for 🐛 Exceptions in batch no longer are shown on the page when Javascript is disabled Needs work that exposes that some of the tests that were failing for that will also fail once they get past that.

  • Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    Not currently mergeable.
  • Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    Not currently mergeable.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    771 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    771 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    771 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
    last update 8 months ago
    771 pass
  • Assigned to phenaproxima
  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA

    This gets all our functional tests passing on the core MR now that we have a temporary fix for 🐛 Exceptions in batch no longer are shown on the page when Javascript is disabled Needs work

  • Issue was unassigned.
  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    🇺🇸United States phenaproxima Massachusetts

    Well, this looks good to me. If it passes tests, go ahead and merge it. No objection here.

  • Comment 8 months ago →
    System Message
    • tedbow → committed f2516c47 on 3.0.x 
      Issue #3391715 by tedbow, phenaproxima: Change core merge request...
  • Status changed to Fixed 8 months ago
  • Comment 8 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Comment 8 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA

    reopening to update the core merge request

  • Comment 7 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA

    Found the first problem https://git.drupalcode.org/issue/drupal-2977515/-/jobs/485380

    I am working in scratch PR right now at 📌 [ignore] Test Package manager core merge Needs work 

    ---- Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Exception Other      phpunit-341.xml      0 Drupal\Tests\package_manager\Kernel
    PHPUnit Test failed to complete; Error: PHPUnit 9.6.15 by Sebastian
    Bergmann and contributors.
    
    Testing Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest
    E.....E..                                                           9 / 9
    (100%)
    
    Time: 00:34.729, Memory: 4.00 MB
    
    There were 2 errors:
    
    1)
    Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest::testSymlinksWithinSamePackage
    Drupal\Core\Extension\InfoParserException: Unable to parse
    core/profiles/demo_umami/demo_umami.info.yml as it does not exist
    
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParserDynamic.php:40
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParser.php:22
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:556
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:318
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:126
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:91
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:300
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:138
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:314
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:155
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:408
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:368
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:396
    /builds/issue/drupal-2977515/core/includes/update.inc:303
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:65
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:45
    /builds/issue/drupal-2977515/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
    /builds/issue/drupal-2977515/core/modules/package_manager/src/StatusCheckTrait.php:50
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php:241
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/SymlinkValidatorTest.php:39
    /builds/issue/drupal-2977515/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
    
    2)
    Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest::testSymlinkToDirectory
    with data set "rsync" ('rsync', array())
    Drupal\Core\Extension\InfoParserException: Unable to parse
    core/profiles/demo_umami/demo_umami.info.yml as it does not exist
    
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParserDynamic.php:40
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParser.php:22
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:556
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:318
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:126
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:91
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:300
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:138
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:314
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:155
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:408
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:368
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:396
    /builds/issue/drupal-2977515/core/includes/update.inc:303
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:65
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:45
    /builds/issue/drupal-2977515/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
    /builds/issue/drupal-2977515/core/modules/package_manager/src/StatusCheckTrait.php:50
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php:241
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/SymlinkValidatorTest.php:185
    /builds/issue/drupal-2977515/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    I have confirm this locally with the AU 3.0.x branch and core 11.x. So it is not a problem with the conversion to the core MR but with our compatiblity with 11.x.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024