- Issue created by @alexpott
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This blocks 📌 Start using gitlab ci in addition to Drupalci for testing Needs work , which slows down the Automatic Updates initiative.
- Status changed to Needs review
11 months ago 10:43am 15 December 2023 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
This is working in https://git.drupalcode.org/project/locale_deploy/-/tree/1.0.x/tests/src/... see 📌 Fix build test on gitlabci Fixed
- Status changed to Needs work
11 months ago 11:07am 15 December 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Only one failure:
1) Drupal\BuildTests\Framework\Tests\BuildTestTest::testCopyCodebaseExclude Failed asserting that file "/tmp/build_workspace_b44d87ed120fbe0c41c5d4572777553dQLQ8rc/copied_codebase/modules/my_module/vendor/my_vendor/composer.json" exists.
Which is extra special, because it's a test for the build test infrastructure, and it uses VFS. It's the only build test test using VFS.
I think the problem is that the build test infra in the MR is using
Composer\InstalledVersions
, but in the VFS mock, there's nothing composer-related? - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I wonder if it would be simpler to not use VFS? 🤔
- Status changed to Needs review
11 months ago 6:01pm 15 December 2023 - Status changed to RTBC
11 months ago 12:24pm 18 December 2023 - Status changed to Downport
11 months ago 5:09pm 18 December 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x (which will also be 10.3.x once it's branched), thanks!
I think we could probably backport this to 10.2.x since it's test only, but can't get my head around whether there's any bc implications for contrib/custom build tests at all - feels like there are not, but leaving PTBP for a bit.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Contrib build tests running on DrupalCI are completely broken atm. I wrote this MR to fix the 1 contrib module I know that has a build test. I think this is worth backporting. As you can see from the MR none of the core build tests have had to change due to this MR - it's only the tests of the build tests that have.
- Status changed to Fixed
11 months ago 11:27pm 18 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.