leaflet-more-maps library should depend on leaflet/leaflet-drupal, not leaflet/leaflet

Created on 16 October 2023, about 1 year ago
Updated 18 February 2024, 9 months ago

Problem/Motivation

Under some circumstances (JS aggregation enabled) we noticed that leaflet_more_maps.js fails because it cannot find Drupal.Leaflet.

Steps to reproduce

Hard to reproduce because it depends on how JS is aggregated or in what order it is loaded.

Proposed resolution

The leaflet-more-maps library declares a dependency on leaflet/leaflet. This is incorrect, because Drupal.Leaflet is set in leaflet.drupal.js from the leaflet/leaflet-drupal library. Changing the dependency to leaflet/leaflet-drupal is needed.

The tiny attached patch fixes this.

πŸ› Bug report
Status

Fixed

Version

2.1

Component

Code

Created by

πŸ‡³πŸ‡±Netherlands dennis_meuwissen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024