Fix all PHPCS warnings and notices

Thanks.

This module has a phpcs.xml that excludes Drupal.Arrays.Array.LongLineDeclaration. In my view that is a mistake for 2023 when screens are large, and anyway other lines of code can be much longer than 80 characters.

The proposed MR fixes all available coding standards warnings and notices and removes custom `phpcs.xml`.
So, our IDE will not mark and try to fix all those lines according to the required standards.

Regarding Drupal.Arrays.Array.LongLineDeclaration. This is a standard for all Drupal core and all Drupal contrib modules.
There is no visible need to customize PHPCS for a single module. It is always better to have and follow the same standards everywhere.
Even more, it's just a few lines of code to fix.

Looking forward to being merged,
thanks!

Many other contrib modules are customising the rules - just search for phpcs.xml on one of your sites.

I do want to help everyone get what they need from this module, but also my time is limited. You make more work for me as maintainer if you argue with absolutely everything😃.

There are at least three drupal-org issues related to the topic "Symfony Mailer and Drupal Core":
- 🌱 [META] Adopt the symfony mailer component Needs review
- ✨ Migration strategy for moving to Symfony Mailer Active
- ✨ Change core modules to use Symfony Mailer Active

If/when/once some parts of this module become a part of the core, it will be required to follow all PHPCS.
So, there will be a need to update those parts of the code to follow all PHPCS (as Drupal core does). It will not committed otherwise.
It's even simpler to do this right now (when we have just a few places to change) instead of changing PHPCS rules for the module (and the number of such places will be increased).

Adam, I would kindly ask you (as the maintainer) to rethink this policy about adding exceptions for some PHPCS rules to the module.
Thanks!

chetan 11 → made their first commit to this issue’s fork.

Hi @bohart
I have fixed all the phpcs issues in symfony_mailer module.
Please check the raised MR & attached screenshot.

• This coding standards messages for this module are shown at https://www.drupal.org/pift-ci-job/2787629 → . Currently there are 9.
• This module has chosen not to fix long array declarations.
• Sorting of use statements is not required by the official test run. I'm willing to do it as a one-off, but they will gradually become less sorted.

Hi Adam,

1) you mentioned https://www.drupal.org/pift-ci-job/2787629 → in your comments on Gitlab.
DrupalCI is outdated; it used outdated `drupal/coder` and will have no updates anymore (as it's deprecated).
The valid link to see PHPCS notices/warnings is on GitlabCI (which uses the latest `drupal/coder` version):
https://git.drupalcode.org/project/symfony_mailer/-/jobs/185760

2) Okay, let's skip the discussion of long array declaration out of this issue. MR updated:
- the source branch rebased and added new commits from 1/x dev branch, so it's mergeable now;
- everything related to long array declaration changes are removed;

Please proceed and commit to the 1.x dev branch: MR !70.
Thanks!

Great thanks for the MR and for showing me about GitLab. There are still some CSS errors if anyone feels like fixing those.

`stylelint` rules applied and `stylelint` job is now green.
Was: https://git.drupalcode.org/project/symfony_mailer/-/jobs/194358
Now: https://git.drupalcode.org/issue/symfony_mailer-3394193/-/jobs/195618

The only thing is about @import 'inline.day.css'; as import can be a part of CSS files (not SCSS or other).
codingStandardsIgnoreLine doesn't work, so codingStandardsIgnoreStart/codingStandardsIgnoreEnd to make all jobs green:
https://git.drupalcode.org/issue/symfony_mailer-3394193/-/pipelines/34328

@Adam, please review MR !73 and merge. Thanks!

@Yashaswi18, please do not commit to other users' branches / MR.

reverted/removed commit 6740e70e by @Yashaswi18 from MR !73, so MR can be reviewed/merged again.

Great thanks. It seems rather picky for it to complain about the order of lines. Anyway, it's good, the job is done.

< just talking mode on >
When a lot of people contribute to some project, that's not picky but quite useful :)
Suppose IDE is appropriately configured (for example, PHPStorm is configured to handle this by default). In that case, all lines will be ordered automatically according to the specified stylelint rules in the project (in our case, they come from Drupal core).
That's why the latest MR was a really quick one; IDE is just fixing everything according to Drupal core stylelint.
< just talking mode off >

Adam, MR !72 can be / should be closed (I have no rights to do so on this module). So, we will not collect a pull of non-needed and opened MRs on the project (which definitely will never be merged).
Thanks!

AdamPS → closed merge request !72

Aha I didn't realise I could close them, thanks for pointing it out. I tidied up a few others too.

Automatically closed - issue fixed for 2 weeks with no activity.