- Issue created by @quietone
- Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @quietone opened merge request.
- last update
about 1 year ago 30,397 pass - last update
about 1 year ago 30,397 pass - last update
about 1 year ago 30,397 pass - last update
about 1 year ago 30,397 pass - Status changed to Needs review
about 1 year ago 10:25am 15 October 2023 - Status changed to RTBC
about 1 year ago 4:14pm 15 October 2023 - πΊπΈUnited States smustgrave
The changes seem good.
Does bring up a question, that's not a blocker. When we change a fixture path/namespace like this is there any worry about breaking a contrib test? Is it bad practice for contrib to use core fixtures?
- π¬π§United Kingdom longwave UK
Tests are generally considered internal and exempt from BC, except for base classes, traits and explicit test API. In this case even though the fixtures are used by a number of tests, they are still not API and we can change them if we need to.
https://www.drupal.org/about/core/policies/core-change-policies/bc-polic... β
-
longwave β
committed 8542020a on 10.2.x
Issue #3394093 by quietone: Correct spelling of corefake (cherry picked...
-
longwave β
committed 8542020a on 10.2.x
-
longwave β
committed eafbd246 on 11.x
Issue #3394093 by quietone: Correct spelling of corefake
-
longwave β
committed eafbd246 on 11.x
- Status changed to Fixed
about 1 year ago 6:26pm 15 October 2023 - π¬π§United Kingdom longwave UK
This is much easier to review with
git diff -M1
which considers all the files as renamed instead of deleted and recreated.Committed and pushed to 11.x and 10.2.x. Did not backport cleanly to 10.1.x, it's eligible as a test-only change but not sure it is worth the effort.
Automatically closed - issue fixed for 2 weeks with no activity.