Provide backwards-compatibility for storage settings in FieldUiTestTrait::fieldUIAddNewField

I reverted one core test to use the old key to see if this works but more will be necessary or we decide to revert more/all?

Thanks @Berdir! This will definitely help other contrib to become Drupal 10.2 compatible and helps with the multi branch compatibility.

I don't think we need to convert all the uses. Maybe we could convert something a bit more involved like \Drupal\Tests\field_ui\Functional\ManageFieldsLifecycleTest so that the only usage doesn't get removed accidentally?

So question, is one way preferred more then another? Should the least preferred one throw a warning or deprecation?

ManageFieldsLifecycleTest doesn't use storage settings. It really is something that's not used a lot, there aren't many storage settings anyway and usually the defaults are fine, at least for tests (Quite a few storage settings IMHO shouldn't be, like most/all things on file/image.

Only found 4 cases in core that set storage settings, 3x it's a field type specific setting and a single case to set the cardinality. I assume there are more cardinality tests, but they are then more involved and don't use the helper.

I just converted all of them, then we can say it's standardized on not including the prefix but doing so will still work. I hope we can avoid a complex deprecation dance or warning or anything like that, it would result in considerable extra complexity and make it much harder to get into core in time for 10.2.

Suppose we could always open a follow up if we ever cared about deprecating the other way.

Committed 2771a31 and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.