- Issue created by @berdir
- Status changed to Needs review
over 1 year ago 12:58pm 21 July 2023 - last update
over 1 year ago 92 pass, 80 fail - 🇨🇭Switzerland berdir Switzerland
First patch, will update when there is an icon that we can use.
- 🇨🇭Switzerland berdir Switzerland
I think we also need a Drupal version check as category has a different meaning in Drupal 10.1 and below.
The last submitted patch, 2: paragraphs-field-type-category-3376124-2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
over 1 year ago 1:15pm 21 July 2023 - 🇪🇸Spain ckrina Barcelona
Here's an SVG for the icon with the same size and colors as the rest of the icons.
- Status changed to Needs review
over 1 year ago 1:59pm 21 July 2023 - last update
over 1 year ago 180 pass - 🇨🇭Switzerland berdir Switzerland
Thank you, looks good I think.
Used the same css as media module, but we use scss, not postcss, so it doesn't do the inline stuff that core is doing, but it works fine:
- Status changed to Needs work
about 1 year ago 10:45am 11 October 2023 - 🇨🇭Switzerland berdir Switzerland
Tests are (as expected) in pretty bad shape in 10.2, here is a GitlabCI Pipeline against it: https://git.drupalcode.org/project/paragraphs/-/pipelines/29079/test_report. That's without this change, which needs to be updated and then all the tests adjusted that are failing.
- last update
about 1 year ago 180 pass - @berdir opened merge request.
- last update
about 1 year ago 178 pass, 2 fail - last update
about 1 year ago 169 pass, 8 fail - last update
about 1 year ago 164 pass, 12 fail - last update
about 1 year ago 176 pass, 4 fail 24:04 23:35 Running- last update
about 1 year ago 180 pass - last update
about 1 year ago 180 pass - last update
about 1 year ago 180 pass - Status changed to Fixed
about 1 year ago 8:30pm 26 October 2023 - Status changed to Active
about 1 year ago 10:45pm 26 October 2023 - 🇨🇭Switzerland berdir Switzerland
There's one related bit that I didn't consider yet, and that is if an ER field type is already set to paragraphs, we break the ability to edit that, while with 10.1, you only can't edit the storage settings.
We should probably change that to do a warning instead or something. Will think about it. with the extra paragraph visibility, we could also consider to just remove it?
Also, 📌 Move field type into Reference group in new Drupal 10.2 field UI Needs work might require further adjustments.
- last update
11 months ago Composer require-dev failure - Status changed to Needs review
11 months ago 10:35am 13 January 2024 - last update
11 months ago 180 pass - last update
11 months ago 180 pass - Status changed to Fixed
11 months ago 12:07pm 13 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.