- Issue created by @lukassykora
- Status changed to Active
about 1 year ago 11:03am 6 October 2023 - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @lukassykora opened merge request.
- Status changed to Needs review
about 1 year ago 4:15pm 6 October 2023 - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 5:31pm 6 October 2023 - πΊπΈUnited States smustgrave
Tagging for test coverage.
Also issue summary appears incomplete. There are several sections of the template that should be left, and this appears to be adding new UI change, possibly API. Also works mentioning the need for this feature helps in the review.
Thanks.
- π³πΏNew Zealand quietone
@lukassykora, thanks for making an MR for this suggestion!
There is an outstanding issue for Drupal core to remove the terms 'whitelist' and 'blacklist' from the code base. There are links in the Issue Summary for this work that explains the reasons, #2993575: Remove usage of "blacklist", "whitelist", use better terms instead β . Because of that the patch needs to updated.
Like #7 mentions the standard template allows us to coordinate work on an issue. Since it is no longer here I have restores the standard template and updated the remaining tasks and it to remove 'whitelist'. I also updated the title.
- First commit to issue fork.
- πΊπΈUnited States kurttrowbridge
I added a new fork,
3392147-allowed-ips
, with the patch provided in #5 plus some inclusive language changes. (Sorry if I didn't do that rightβthe amount that the existing MR had changed in unrelated files threw me off, so I was hesitant to try to build on top of it.) I also did a little bit of formatting cleanup, but that probably wasn't exhaustive.One thing I'm confused by is that when I look at the allowlist, the IP addresses won't show up in the column (see attached screenshot)βsomething seems off with how the ID and Allowlisted IP properties are defined and saved, but I haven't yet figured out what. Additionally, it looks like the IP address is intended to be saved as the entity ID; this works for IPv4 addresses, but causes a fatal error ("Invalid character in Config object name") when allowing IPv6 addresses due to the colons (
:
) in the address. - Status changed to Postponed
about 1 month ago 4:51am 21 November 2024 - π³πΏNew Zealand quietone
The Ban Module was approved for removal in π [Policy] Deprecate Ban module in Drupal 10 and move it to contrib for Drupal 11 Active .
This remains Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project β and the Extensions approved for removal β policies.
The deprecation work is in π± Deprecate Ban module Active and the removal work in π [12.x] [Meta] Tasks to remove Ban module Postponed .
Ban will be moved to a contributed project after the Drupal 12.x branch is open.
- π³πΏNew Zealand quietone
I also meant to change this to un-assigned.