- Issue created by @bluegeek9
- Assigned to Shreya_98
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 8:27am 6 October 2023 - 🇮🇳India Shreya_98
Hi @bluegeek9,
I have fixed this issue i.e. watchdog_exception() deprecated in RebuildIpAddressService.php. Kindly review the attached patch file. - Status changed to Needs work
about 1 year ago 4:07pm 6 October 2023 - 🇺🇸United States bluegeek9
Hi @Shareya_th,
Here is an example of replacing watchdog_exception() with Error::logException():
https://git.drupalcode.org/project/search_api/-/merge_requests/87/diffs - Assigned to Shreya_98
- Issue was unassigned.
- Assigned to sarwan_verma
- 🇮🇳India sarwan_verma
Hi @bluegeek9,
I have fixed this issue watchdog_exception() and also attached patch,
please review and verify. - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:31am 9 October 2023 - Status changed to Postponed
about 1 year ago 7:19pm 13 December 2023 - 🇺🇸United States bluegeek9
The pull request looks good. I am postponing merging since Drupal 9 will not work with this change. I don't want to drop support for D9 yet.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Aren't the use statements incorrect?
use \Drupal\Core\Utility\Error;
Should be
use Drupal\Core\Utility\Error;
- 🇺🇸United States bluegeek9
@trackleft2,
You are correct, but you also need to look at the merge request, not the patch(es).
https://git.drupalcode.org/project/visitors/-/merge_requests/104/diffs
- Status changed to Fixed
8 months ago 9:33pm 23 April 2024 -
bluegeek9 →
committed 5c23ddca on 8.x-2.x authored by
sarwan_verma →
Issue #3392006 by bluegeek9, sarwan_verma: watchdog_exception()...
-
bluegeek9 →
committed 5c23ddca on 8.x-2.x authored by
sarwan_verma →
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States bluegeek9
This issue was resolved. A new release, 8.x-2.17, will be made soon, May 31st.
This is an excellent opportunity to beta test the dev branch, and report any issues.
Contributors (5)
bluegeek9 → , roshni27 → , abhishek_gupta1 → , sarwan_verma → , SandeepSingh199 →
Changelog
Issues: 32 issues resolved.
Changes since 8.x-2.16 → :
Bug
- #3432630 → : Remove Not rendering HTML
- #3395217 → by bluegeek9 → : On a fresh install of a Drupal site with this module included, we get dependency errors
- #3400985 → by bluegeek9 → : Site break when placed visitors module
- #3413155 → by abhishek_gupta1 → , bluegeek9 → : Give Default value to all $agent keys
- #3383142 → by bluegeek9 → : ParseError: syntax error, unexpected
- #3380760 → : Warning: Undefined array key
Feature
- #3376256 → : Page Performance Metrics
- #3378568 → : Ajax Replace Report
- #3376234 → : Route reports
- #3378580 → : Browser Report(s)
- #1087268 → by bluegeek9 → : Exclude robots from the statistics
- #3376233 → by bluegeek9 → : View filter date range
- #3369318 → : Log OS and device infomation - BrowserCap replacement
- #3376235 → by bluegeek9 → : Drush command: Download MaxMind database
- #3250285 → by bluegeek9 → : Performance: Add db indexes
Task
- #3389685 → : Three different errors displayed
- #3376397 → by bluegeek9 → , roshni27 → : Remove block settings from visitors.config
- #3376392 → : Move Visitors Report menu
- #3444385 → : Module path
- #3443031 → by bluegeek9 → : Issues reported by PHPCS
- #3392006 → by bluegeek9 → , sarwan_verma → : watchdog_exception() deprecated
- #3423013 → : Deprecated function user_role_names()
- #3423001 → by bluegeek9 → : composer.json missing "repositories"
- #3397326 → by bluegeek9 → , SandeepSingh199 → : Issues reported by PHPStan
- #3401384 → : Remove Drupal 9 from GitLab CI
- #3393046 → by bluegeek9 → : Code Coverage
- #3377961 → : Replace visitors/hosts reports with views
- #3377962 → : Replace visitors/hits with Views
- #3377964 → : Replace /visitors/pages with Views
- #3377960 → by bluegeek9 → : Log visitor local time
- #3376241 → : Drush Command: Rebuild Geo Location
- #3377958 → : Tracking cookies