Circular reference detected because of EntityTypeInfo

Thank you for reporting.

Can we get a test case showing the issue?

Even if there's a reproducible bug we don't need test coverage to remove dead code. It would be good to confirm that there's some existing test coverage for the class though.

Haven't looked at the code in detail but do we need to consider backward compatibility in the constructor, in case someone has extended this?

The class was marked internal so that means we’re safe right?

As it's @internal, yes we're safe to do this with no BC. I checked contrib anyway and found that at one time https://www.drupal.org/project/config_entity_revisions → did extend this class but it doesn't appear to any more in the currently supported release at least. I didn't find any other references to it so I think we're safe.

CC failure though

Removing tests tag pe #3

Try to Fix CCF error.

Aditi Saraf → made their first commit to this issue’s fork.

Failure is fixed in #8, moving back to NR.

Verified EntityTypeInfo.php is an @internal class so no BC concerns I believe.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)