Fix PHPStan L1 error "Variable $foo in/on something() is never defined."

Applied the MR and searched for is never defined\\.$#" and all instances have been replaced.

Tests are all green and I don't see anything glaring with the updates.

LGTM!

Added some comments to the MR.

Thanks @alexpott!

Addressed threads, back to NR.

We need a little change to the node grants changes. The test is testing the no node_grants implementations case.

Thanks @alexpott (again).

Unsure if this:

We need a little change to the node grants changes. The test is testing the no node_grants implementations case.

is covered by the reverting of the changes?

This looks fine now. And yes test coverage exists that the message is there for both the batch and non-batch cases. The reason this is not an issue is the message system automatically deduplicates messages.

Remarking, seems all threads have been addressed.

Committed and pushed 6eaf9fa3c37 to 11.x and 66ddcd2abd3 to 10.2.x. Thanks!

Spokje → closed merge request !4928

Automatically closed - issue fixed for 2 weeks with no activity.