Menu isn't translated after patch applying

Created on 2 October 2023, about 1 year ago

Problem/Motivation

After applying the patch from https://www.drupal.org/project/i18n/issues/3153577 🐛 Only Variables can be passed by reference i18n_menu module Fixed , some menus are not being translated anymore. I've looked it the patch and noticed that it had thrown away passing by reference and hadn't replaced it with smth instead.
So the link title is translated but not passed back.

Proposed resolution

To deal with "Fatal error: Only variables can be passed by reference" from the https://www.drupal.org/project/i18n/issues/3153577 🐛 Only Variables can be passed by reference i18n_menu module Fixed , that appears when $item['link'] is not set on 7.4 and below, I suggest to add check for existence of $item['link'].

🐛 Bug report
Status

Needs review

Version

1.0

Component

Menus

Created by

Live updates comments and jobs are added and updated live.
  • PHP 8.1

    The issue particularly affects sites running on PHP version 8.1.0 or later.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024