[1.1.0] Replace download-block/download-link with card--download/link--donwload/tile--download (1.10 changelog)

Open on Drupal.org →

Created on 27 September 2023, 9 months ago

Updated 22 April 2024, 2 months ago

Problem/Motivation

According to DSFR 1.10 changelog, download-block/download-link are deprecated, and should be replaced by card/link/tile download variants.
https://github.com/GouvernementFR/dsfr/releases/tag/v1.10.0
DSFR documentation : https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/te...

Proposed resolution

I see 3 possible ways of dealing with that :

create a new "download" pattern with 3 variants (card, link or tile)
or create 3 new patterns : card-download, link-download, tile-download, as their HTML structure is quite different
or add variants on the existing card/tile/link patterns to handle the download appearance

I think the first way would be the best, if that pattern can "call" the current card/link/tile patterns in order to reuse the HTML structure and not rewrite it.

✨ Feature request

Status

Needs work

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @mh_nichts
Comment 7 months ago →
🇫🇷France pdureau Paris
Comment 5 months ago →
🇫🇷France pdureau Paris
Comment 3 months ago →
🇫🇷France pdureau Paris
Proposal:

Keep download_block component but add "(Deprecated)" at the end of component label. We keep them in order to not introduce a breaking change.

Add needed props to:

link component: Add "download" variant or boolean prop (if can be associated with other variants); Add "detail" slot; What else?

tile component: Add "download" variant or boolean prop (if can be associated with other variants); What else?

card component: Add "download" variant or boolean prop (if can be associated with other variants); What else?
First commit to issue fork.
Assigned to yassrzg
Status changed to Needs work 3 months ago5:00pm 29 March 2024
Comment 3 months ago →
yassrzg
Comment 2 months ago →
🇫🇷France pdureau Paris

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024