- Issue created by @phenaproxima
- πΊπΈUnited States effulgentsia
Thanks for opening this. First question: what are the pros/cons of triggering the deprecation when label() is called vs. when the view is saved?
- πΊπΈUnited States phenaproxima Massachusetts
My $0.02:
The main pro is that you'll know sooner if you have an invalid view;
label()
is more likely to be called in the normal course of things thanpreSave()
, especially for views that don't change frequently.The main con is that
label()
is a strange place to put the deprecation, because indeed, you really shouldn't be able to save a view without a label.To me, the conclusion is that both places should trigger the deprecation, with slightly different wording in each.
- Assigned to effulgentsia
- Status changed to Needs review
about 1 year ago 11:30am 2 October 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The main pro is that you'll know sooner if you have an invalid view
+1
- Status changed to Active
about 1 year ago 3:05pm 20 October 2023 - πΊπΈUnited States smustgrave
Moving to active as consensus seems to be this is a good task to have.