- Issue created by @thomas.frobieter
- Issue was unassigned.
- 🇩🇪Germany Anybody Porta Westfalica
Someone please needs to find out, if this only happens for formatters within layout builder or also happens for regular entity formatters.
photoswipe_update_9003()
is responsible for updating the field formatters.So could someone please provide details, when this happens and when not?
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
My bet is, that this is "just" an issue with layout builder. Layout builder leads to different structures in the entity displays that need to be handled.
Luckily I found some other projects that had similar issues and code:
- #3251489: updb doesn't check layout builder fields. → (fixed)
- 🐛 Update the link setting for Title Formatter in Layout Builder. Needs review (to review)
Guess we can be quite sure such a solution needs to be adopted?
- First commit to issue fork.
- 🇩🇪Germany Grevil
Ok, I just tested this, and indeed the formatter settings are only still there for entities NOT using Layout Builder. Any entity using layout builder will have all of their formatter settings reset (except "Photoswipe modal image style" for some reason).
- Status changed to Needs review
over 1 year ago 8:31am 26 September 2023 - Assigned to Anybody
- last update
over 1 year ago 21 pass - @anybody opened merge request.
- Assigned to Grevil
- Status changed to Needs work
over 1 year ago 12:24pm 26 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Nice work @Grevil! I left some final comments to make it more bulletproof. Afterwards please test it one last time and I'll do the final review!
- last update
over 1 year ago 21 pass - Assigned to Anybody
- Status changed to Needs review
over 1 year ago 12:55pm 26 September 2023 - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 12:57pm 26 September 2023 - last update
over 1 year ago 21 pass - Status changed to Fixed
over 1 year ago 1:00pm 26 September 2023 - Assigned to Grevil
- Status changed to Needs work
over 1 year ago 1:10pm 26 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Seems we were too quick:
[notice] Update started: photoswipe_update_9005 [warning] Undefined array key "photoswipe_caption" photoswipe.install:276 [warning] Undefined array key "photoswipe_caption_custom" photoswipe.install:277 [warning] Undefined array key "photoswipe_node_style" photoswipe.install:284 [warning] Undefined array key "photoswipe_node_style_first" photoswipe.install:285 [notice] Update completed: photoswipe_update_9005
and in one case photoswipe_caption: 'alt' was modified to null
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 2:49pm 26 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.