- Issue created by @kopeboy
- 🇩🇪Germany jurgenhaas Gottmadingen
Good finding, thanks @kopeboy
To clarify this a bit further: defining the 2 events for access and response, the second argument can be left empty. But the request needs to provide a second argument, which can be any string. So, declaring the second argument optional is technically correct, but either the route declaration or the route matcher need to be more tolerant, accepting an empty second argument in such cases.
- Merge request !391Issue #3389309: ECA Endpoint not found without second path argument → (Merged) created by jurgenhaas
- last update
about 1 year ago 297 pass - Status changed to Needs review
about 1 year ago 7:49am 24 September 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Declaring a second route which expects only 1 argument seems to be working fine both ways, i.e. it works with just 1 argument if the ECA model has no second argument defined, and it also works the other way round, that the second argument is required in the request if the model has that defined.
- 🇩🇪Germany jurgenhaas Gottmadingen
An alternative approach could probably be to define a default value for the second, i.e. optional parameter. See https://www.drupal.org/docs/8/api/routing-system/parameters-in-routes/us... →
- Status changed to RTBC
9 months ago 1:49pm 23 February 2024 - 🇩🇪Germany danielspeicher Steisslingen
For me, it is ok.
Shall we open another ticket with that alternative approach you mentioned https://www.drupal.org/project/eca/issues/3389309#comment-15347615 📌 ECA Endpoint not found without second path argument RTBC ?
-
jurgenhaas →
committed 76729291 on 2.0.x
Issue #3389309 by jurgenhaas, kopeboy, danielspeicher: ECA Endpoint not...
-
jurgenhaas →
committed 76729291 on 2.0.x
- 🇩🇪Germany jurgenhaas Gottmadingen
Shall we open another ticket with that alternative approach
Don't think so, it was mentioned as an alternative approach, not additional. But I've now merged !391, so that does the job, nothing else required.
-
jurgenhaas →
committed 0b96be9d on 1.1.x
Issue #3389309 by jurgenhaas, kopeboy, danielspeicher: ECA Endpoint not...
-
jurgenhaas →
committed 0b96be9d on 1.1.x
- Status changed to Fixed
9 months ago 2:06pm 23 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.