ECA Endpoint not found without second path argument

Created on 23 September 2023, over 1 year ago
Updated 8 March 2024, 11 months ago

Problem/Motivation

When you set ECA Endpoint Access and Response without a second path argument, the response is a Page not found.
I file this as a bug since the modeller UI calls the second argument "optional", but it seems required. Adding any string to it will give you a working response.

Tested with latest version (cloned after commit #865f7fc982d07407edab0e8773ace9e5de67847f).

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇮🇹Italy kopeboy Milan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kopeboy
  • 🇩🇪Germany jurgenhaas Gottmadingen

    Good finding, thanks @kopeboy

    To clarify this a bit further: defining the 2 events for access and response, the second argument can be left empty. But the request needs to provide a second argument, which can be any string. So, declaring the second argument optional is technically correct, but either the route declaration or the route matcher need to be more tolerant, accepting an empty second argument in such cases.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    297 pass
  • Status changed to Needs review over 1 year ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    Declaring a second route which expects only 1 argument seems to be working fine both ways, i.e. it works with just 1 argument if the ECA model has no second argument defined, and it also works the other way round, that the second argument is required in the request if the model has that defined.

  • 🇩🇪Germany jurgenhaas Gottmadingen

    An alternative approach could probably be to define a default value for the second, i.e. optional parameter. See https://www.drupal.org/docs/8/api/routing-system/parameters-in-routes/us...

  • Status changed to RTBC 11 months ago
  • 🇩🇪Germany danielspeicher Steisslingen

    For me, it is ok.

    Shall we open another ticket with that alternative approach you mentioned https://www.drupal.org/project/eca/issues/3389309#comment-15347615 📌 ECA Endpoint not found without second path argument RTBC ?

  • Pipeline finished with Skipped
    11 months ago
    #102471
  • Pipeline finished with Skipped
    11 months ago
    #102472
    • jurgenhaas committed 76729291 on 2.0.x
      Issue #3389309 by jurgenhaas, kopeboy, danielspeicher: ECA Endpoint not...
  • 🇩🇪Germany jurgenhaas Gottmadingen

    Shall we open another ticket with that alternative approach

    Don't think so, it was mentioned as an alternative approach, not additional. But I've now merged !391, so that does the job, nothing else required.

    • jurgenhaas committed 0b96be9d on 1.1.x
      Issue #3389309 by jurgenhaas, kopeboy, danielspeicher: ECA Endpoint not...
  • Status changed to Fixed 11 months ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    This is now also back ported to 1.1.x

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    10 months ago
    Total: 274s
    #131494
  • Pipeline finished with Success
    10 months ago
    #131496
  • Pipeline finished with Success
    3 months ago
    Total: 2828s
    #329638
  • Pipeline finished with Success
    3 months ago
    Total: 554s
    #332817
  • Pipeline finished with Skipped
    2 months ago
    #333229
  • Pipeline finished with Success
    about 1 month ago
    Total: 584s
    #369724
  • Pipeline finished with Failed
    about 1 month ago
    Total: 802s
    #369765
  • Pipeline finished with Failed
    13 days ago
    Total: 178s
    #390647
  • Pipeline finished with Success
    13 days ago
    Total: 157s
    #390653
  • Pipeline finished with Success
    13 days ago
    Total: 166s
    #390674
Production build 0.71.5 2024