- Issue created by @Anybody
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @anybody opened merge request.
- Assigned to thomas.frobieter
- Status changed to Needs review
over 1 year ago 9:54am 18 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter: Here's the fix, but I guess this may mean the
['optionset']
variable changed or didn't exist anymore?
So we should check that in detail for a case where we expect it.Once we're use it still works as expected, this can be merged. The fix is definitely correct, but we should be warned here...
Yeah, it doesn't work anymore. Sure, unrelated to the fix here, but we need to fix the functionality, even if its only for legacy reasons (see: ✨ Introduce layout_slideshow layout paragraph type and deprecate old "container_slides" paragraph Needs work ).
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to Anybody
Okay, this was a easy one, please review: https://git.drupalcode.org/issue/drowl_paragraphs-3387952/-/commit/78f74858e4554b055d0ac67e79c76247a3bd2de7
- Assigned to thomas.frobieter
- Status changed to Needs work
over 1 year ago 1:05pm 18 September 2023 I don't have a comment for the fallback reason, not more then I've already wrote. We can remove this with the risk of damaging pages with older versions.
- 🇩🇪Germany Anybody Porta Westfalica
Yeah let's just add that "Fallback for older versions:" as comment. So we know we can probably remove it one day and understand what it was for.
Its already there ;) "Support for older versions of the blazy/slick modules"
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter perfect, then only the code style fix is left, can be merged afterwards.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to RTBC
over 1 year ago 3:52pm 20 September 2023 - Status changed to Fixed
over 1 year ago 3:54pm 20 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Needs work
over 1 year ago 7:55am 5 October 2023 @anybody got this error again on project DD .. guess we need to fix this too in the 8.x-3.x and 8.x-1.x branches..
- 52f77737 committed on 8.x-1.x
Issue #3387952 by Anybody, thomas.frobieter: Warning: Undefined array...
- 52f77737 committed on 8.x-1.x
- e4d8d43a committed on 8.x-3.x
Issue #3387952 by Anybody, thomas.frobieter: Warning: Undefined array...
- e4d8d43a committed on 8.x-3.x
- Status changed to Fixed
over 1 year ago 8:15am 5 October 2023 - Issue was unassigned.
- 🇩🇪Germany Anybody Porta Westfalica
Well done, thank you @thomas.frobieter! :)
Automatically closed - issue fixed for 2 weeks with no activity.