missing license URL

@nojj Which URL did you use?
There is no LICENCE file present on the git.

I just added a MIT license URL for testing:

license:
     name: MIT
     url: https://opensource.org/license/mit/
     gpl-compatible: true

Shreya_th → made their first commit to this issue’s fork.

@aaron ,
I have added license url in views_slideshow.libraries.yml and also created MR for this issue . Kindly review the changes.

In the commit from comment #5 was an extra space before the key "url" being added that caused the yml parser to fail with the following error:

Drupal\Core\Asset\Exception\InvalidLibraryFileException: Invalid library definition in modules/contrib/views_slideshow/views_slideshow.libraries.yml: A colon cannot be used in an unquoted mapping value at line 33 (near " url: https://opensource.org/licenses/MIT"). in Drupal\Core\Asset\LibraryDiscoveryParser->parseLibraryInfo() (line 367 of core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php).

I've updated the branch associated with MR !8 to remove the extra space.

Switching to "Needs Review"

Works for me. Thank you!

Used this link with composer-patches and seems to solve the problem.
This approach is also the recommended way to solve this according to core issue 🐛 Log an error message when library definitions have a license with no URL defined Needs work

Use of the MIT license seems a correct assumption also (from https://github.com/briancherne/jquery-hoverIntent/blob/master/jquery.hov... ) :

* You may use hoverIntent under the terms of the MIT license. Basically that
* means you are free to use hoverIntent as long as this header is left intact.
* Copyright 2007-2019 Brian Cherne

Don't think we need tests for this, but might be wrong. Marking this RTBC anyway.

Link used for patch:
https://git.drupalcode.org/project/views_slideshow/-/merge_requests/8.diff

Copy of patch from https://git.drupalcode.org/project/views_slideshow/-/merge_requests/8.diff attached, to be used with composer, see "Patches from drupal.org merge request URLs are dangerous?".

+1: Reviews and tested 👍

I have opened a PR here: https://github.com/briancherne/jquery-hoverIntent/pull/86

Confirming RTBC

The GitHub PR from #13 🐛 missing license URL RTBC has been merged, further confirming the MIT license.

Thanks y'all

Automatically closed - issue fixed for 2 weeks with no activity.