[random test failure] Random failure in ThrobberTest::testProgressThrobberPosition

Seems like a simple update and didn't break anything!

This seems good, I'm also seeing random test failures in HEAD on gitlab for this test: https://git.drupalcode.org/project/drupal/-/jobs/113782

Including the one on the pipeline for this MR: https://git.drupalcode.org/issue/drupal-3387772/-/jobs/93792

We probably need to fix that at the same time as this, otherwise it's hard to show this issue hasn't introduced a new failure.

Spokje → closed merge request !4807

Well, that wasn't the most "inspired" test I've encountered.
Extra joy-bonus for 100% failing to pass locally because of clinking a link text and that waiting for the exact same text.

Anyway, let's see if this is any better.

One (per usual) SQLSTATE[HY000]: General error: 5 database is locked exception in the SQLite run in 10.000 runs vs 3 actual failures in 5000 runs of the current test.

Actual fix in the MR.

Open thread and then can mark.

Going to change some stuff and answer thread.

Moved dropbutton throbber test to the existing test to prevent an extra setup/teardown.

Testing new solution

Works, besides the usual SQLite locked DB failure, also seems quite a bit faster:

- Old on PHP 8.2/MySQL 8 1000x

22 min build duration;

- New 2000x

24 min build duration;

Answering the thread from @catch:

One question - is this hold_test_response() stuff still necessary after the other changes? It's only used in this test and MediaLibraryTestBase now.

Yes, we do.

We're testing AJAX behaviour _before_ the response arrives and the throbber/whatever is replaced with the actual response.
Somehow hold_test_response works, due to delaying the response by writing to a file it seems.

Most of the time we're "saved" by the slowness of Drupal CI and the test is finished before the response arrives. However GitLab seems a tad quicker, thus more random failures on testing this stuff.

The whole methodology is besides non-documented not really deterministic, opened 📌 Refactor AJAX-testing hold_test test module Active to do something more in the way we did in ✨ Add a way to delay executions in test runner until terminate event completed in the child site Fixed .

TLDR: Yes, we need it now and in the future, but we need a better way to temporary delay responses to be able to test "inbetween AJAX response-time" behaviour.

All threads appear to be addressed.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Spokje → closed merge request !4870

Automatically closed - issue fixed for 2 weeks with no activity.