- Issue created by @Spokje
- last update
10 months ago 30,158 pass - @spokje opened merge request.
- Status changed to Needs review
10 months ago 11:43am 15 September 2023 - Status changed to RTBC
10 months ago 1:52pm 15 September 2023 - 🇺🇸United States smustgrave
Applied the MR and searched for "#^Variable \\$selection in empty and only 1 instance which was fixed
LGTM
- last update
10 months ago 30,161 pass - last update
9 months ago 30,168 pass - last update
9 months ago 30,168 pass - last update
9 months ago 30,205 pass - last update
9 months ago 30,208 pass - last update
9 months ago 30,350 pass, 2 fail - last update
9 months ago 30,360 pass - Status changed to Fixed
9 months ago 6:43pm 30 September 2023 - 🇺🇸United States xjm
It wasn't clear from the diff alone why this mixup existed, but reading
EntityDeleteMultipleAccessCheck::construct()locally makes it clear where it got out of sync.Adding credit for @smustgrave for the scope check.
Committed to 11.x. I went back and forth on whether to backport this. Technically, this could disrupt contrib that was setting the member to the factory because that's what the typehint told them to do. That's edgecase enough that I think it's okay for a minor, but I decided to err on the side of caution and not backport it to a 10.1.x patch release.
Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.