- Issue created by @jannakha
- Assigned to chetan 11
- Assigned to thomas.frobieter
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter what do you think about the suggestion?
We could instead wrap it into element-invisible (which I think would be the correct Drupal Standard for a11y Either solution could break things, especially if themes display this text by increasing the font size.
Not really sure why a theme/framework would override this 0px by default, sounds like a badly coded CSS reset or something.However, the 0px solution doesn't follow Drupal standards, and the title approach seems a bit safer in terms of destroying existing designs.
If we solve it with title or .element-invisible, that link should live in the Twig template instead. Otherwise it is not easy for themers to override.
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter thanks! Would you prefer the title attribute or the element-invisible if both are possible?
I tend to go for the title, as it reduces the chance of breaking things.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @anybody opened merge request.
- last update
about 1 year ago 31 pass, 2 fail - last update
about 1 year ago 31 pass, 2 fail - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:22pm 16 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
Okay here we go, @jannakha could you check the result?
Not sure if we should also add the text to the link and wrap it invisible:
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Link.php/...For hiding elements see https://www.drupal.org/docs/accessibility/hide-content-properly →