- Issue created by @shweta__sharma
- Status changed to Needs review
10 months ago 6:56am 13 September 2023 - last update
10 months ago Custom Commands Failed I have attached a patch for the same, also attached after patch screenshot for reference. please review
- last update
10 months ago Custom Commands Failed - Status changed to Needs work
10 months ago 1:09pm 13 September 2023 - 🇺🇸United States smustgrave
I wouldn’t recommend digging through the figmas so much. There were design changes made before launch that aren’t included. So there’s a chance these can be closed won’t fix.
- 🇮🇳India Hamid.ali
I have tested the patch mentioned in Comment 3 and have identified several discrepancies when compared to the Figma design:
- The total number of visible items on Figma is 7
- The selected item colour, is not the same as per the Figma
- On hover, there is a blue border on the Figma which is missing
- When the first item is selected prev and the first buttons are hidden not disabled like in the Figma
- There are no ellipses on the Figma which is present in this case
- The colour of the numbers of the pagination item on select and hover are black in this case colour does not match as well - Status changed to Needs review
9 months ago 9:48am 16 October 2023 - 🇮🇳India Vinayak.Ambig
smustgrave with respect #4 can you please provide the reference where we may verify the deviations. According to that we can progress.
- Status changed to Needs work
9 months ago 1:00pm 16 October 2023 - 🇺🇸United States smustgrave
They aren’t in the figmas anywhere but talking with the maintainer I know some changes were made. Which is why I wouldn’t recommended digging through the figmas looking for differences. 9/10 are probably working as designed.
So unless this provides an improvement, which haven’t tested, not sure this will make it. But could be wrong