- Issue created by @pixelwhip
- Status changed to Needs work
over 1 year ago 5:30pm 12 September 2023 - πΊπΈUnited States pixelwhip
This merge request has not been tested and does not yet include the built assets.
- Assigned to jldust
- πΊπΈUnited States jldust
I agree that this needs to utilize @use instead of @import, also this should be on the 5.x branch.
- @philip_stier opened merge request.
- πΊπΈUnited States philip_stier Denver, Colorado
@jldust / @pixelwhip - I opened a new branch off of 5.x and updated the WYSIWYG file to use `@use` statements. I didn't add the class wrapper, but do we really need it? As long as the styles that are being defined for the front end are also being loaded into CKEditor, we shouldn't need the wrapper?
- Status changed to Needs review
over 1 year ago 5:22pm 14 September 2023 - Status changed to Needs work
over 1 year ago 7:44pm 15 September 2023 - πΊπΈUnited States philip_stier Denver, Colorado
@pixelwhip explained to me that CKEditor5 is now not loaded as an iFrame, versus how CKEditor4 is being loaded, so if we don't load our styles inside of the CKEditor wrapper class, they will be applied to the admin theme as a whole.
- πΊπΈUnited States philip_stier Denver, Colorado
@jldust / @pixelwhip - I've gone the route of using mixins for necessary theming that is needed for CKEditor. I've added comments everywhere that I am doing this to be clear on what is going on.
- Status changed to Needs review
over 1 year ago 3:49pm 20 September 2023 - Status changed to RTBC
over 1 year ago 5:17pm 20 September 2023 - πΊπΈUnited States jldust
Thanks for these changes, I've merged this in and it will be included in the next tagged release.
- Status changed to Fixed
over 1 year ago 5:55pm 20 September 2023 - Status changed to Fixed
over 1 year ago 6:24pm 20 September 2023 - πΊπΈUnited States jldust
This has been included in the 5.x.2-alpha1 releases.