Improve JS selector

Hi @grimreaper, Could you please provide the steps to reproduce from Vanilla Drupal Install?

After some testing, it was due to my front theme (ui_suite_bootstrap) which provides template suggestions.

On custom projects with subtheme I have code that calls again gin_lb_theme_suggestions_alter($suggestions, $variables, 'input') so the gin_lb suggestions are taken into account and then it is ok.

Looking at the JS in https://git.drupalcode.org/project/gin_lb/-/blob/1.0.x/js/gin_lb_toolbar..., I would be in favor of changing the selector ".glb-primary-save" into ".js-glb-primary-save", prefixing CSS classes used by JS code by 'js-' is a good practice to avoid confusion and separating classes for CSS and the ones for JS.

And then in the selector "#gin_sidebar .form-actions .glb-button--primary", ".glb-button--primary" may be not restrictive enough, we may encounter side effect with a potentially other buttons.

@Christian.wiedemann, What is your opinion on this proposal?

Discussed with @Christian.wiedemann on friday 22/09/2023. Ok

Grimreaper → credited Christian.wiedemann → .

Automatically closed - issue fixed for 2 weeks with no activity.