- Issue created by @cmlara
- First commit to issue fork.
- last update
9 months ago 21 pass - 🇮🇳India sarwan
Hi @cmlara,
I have fixed this issue Remove 'sms' from tfa_user_settings also created the patch ,
please review and verify. - Status changed to Needs review
9 months ago 7:13am 29 September 2023 - last update
9 months ago 21 pass - Status changed to Needs work
9 months ago 6:51pm 29 September 2023 - 🇺🇸United States cmlara
@kalash-j This still needs an update hook.
@sarwan I'm not sure how you generated your patch, however it appears to have regressions present.
- Status changed to Needs review
2 months ago 12:06pm 21 April 2024 - 🇺🇸United States cmlara
I have a few concerns, especially around the new PHPStan warnings, the lack of batch usage in the update hook and the lack of testing to go with it.
I apparently had a version of this already in my local repo that I never pushed that resolved most of the concerns. I've pushed it up to the MR, however I don't honestly recall if there was anything left to do with it.
I may have been distracted by the 8.x-1.5 security fix, or the other security code issues or I may have been distracted working on the Core bug that UserData returns strings instead of integers.