Remove 'sms' from tfa_user_settings

Hi @cmlara,
I have fixed this issue Remove 'sms' from tfa_user_settings also created the patch ,
please review and verify.

@kalash-j This still needs an update hook.

@sarwan I'm not sure how you generated your patch, however it appears to have regressions present.

@cmlara created update hook for MR!37

I have a few concerns, especially around the new PHPStan warnings, the lack of batch usage in the update hook and the lack of testing to go with it.

I apparently had a version of this already in my local repo that I never pushed that resolved most of the concerns. I've pushed it up to the MR, however I don't honestly recall if there was anything left to do with it.

I may have been distracted by the 8.x-1.5 security fix, or the other security code issues or I may have been distracted working on the Core bug that UserData returns strings instead of integers.

kalash-j → closed merge request !82

Hi, I've applied the MR !37 as a patch and it applied with no error. The module is working fine after applying the patch and not getting any issue while using two factor authentication for login. As the MR is resolving the issue, hence moving the issue status to RTBC. I'm also attaching the video clips for before and after fixes of the issue.

Commiting to dev.

As this is minor I'm going to skip back-porting to 1.x.

Automatically closed - issue fixed for 2 weeks with no activity.