- Issue created by @catch
- Status changed to Needs review
over 1 year ago 11:18am 11 September 2023 - ๐ฌ๐งUnited Kingdom catch
Help topics test already installs and uninstalls every module. I have moved the hook help verification from InstallUninstallTest to help module so we don't lose that coverage.
That means the only coverage we lose here is trying to reinstall all modules at once after they've previously been uninstalled.
- last update
over 1 year ago 30,144 pass, 2 fail - @catch opened merge request.
- Status changed to Needs work
over 1 year ago 2:57pm 11 September 2023 - last update
over 1 year ago 30,145 pass - Status changed to Needs review
over 1 year ago 3:53pm 11 September 2023 - ๐ฌ๐งUnited Kingdom catch
Need to ignore hidden modules.
Also I opened ๐ Add GenericModuleTestBase and use it to test general module things Downport which would handle one more bit of lost test coverage - if we add that base class, then every core module could test itself being installed, uninstalled, then installed again. No way to do that efficiently without making it a per-module test though so a bit of a bigger change.
- Status changed to RTBC
over 1 year ago 4:51pm 11 September 2023 - ๐ฌ๐งUnited Kingdom longwave UK
As the finder of a reinstall bug in the past - #2534532: Cannot reinstall Forum after it was previously installed โ - I am kinda sad to see this go, but if we can replace it with a generic test that can be used by all modules, that would be even better. I suppose it's a shame that data providers cannot be parallelised.
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Should we not add the generic coverage suggested to replace this before / at the same time as removing it?
- Status changed to Postponed
over 1 year ago 11:28pm 11 September 2023 - ๐ฌ๐งUnited Kingdom catch
We could probably merge this with ๐ Add GenericModuleTestBase and use it to test general module things Downport and remove HelpTopicsSyntaxTest at the same time. However having this MR open made ๐ [PP-2] Speed up gitlab ci runs Postponed easier to work on, so let's instead postpone it on that issue, and close it once it gets done.
- Status changed to Active
about 1 year ago 1:25am 26 September 2023 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
๐ Add GenericModuleTestBase and use it to test general module things Downport is in so this can go back to active.
- Status changed to Closed: duplicate
about 1 year ago 8:31am 26 September 2023 - ๐ฌ๐งUnited Kingdom catch
๐ Add GenericModuleTestBase and use it to test general module things Downport removed InstallUninstallTest too in the end, marking this as duplicate.