Get rid of InstallUninstallTest

Created on 11 September 2023, about 1 year ago
Updated 26 September 2023, about 1 year ago

Problem/Motivation

InstallUninstallTest is a general smoke test that enables then uninstalls every module one by one via the UI, then enables every module via the UI a second time.

It has caught some bugs in the past, but per ๐Ÿ“Œ InstallUninstallTest is taking 20 minutes to run Closed: duplicate it is very slow.

On gitlabCI we have reduced the time taken for a full tes run to 15-17 minutes, I estimate that at least two minutes of that are exclusively due to InstallUninstallTest which appears to take around 12 minutes or so. Because linting and unit tests run first and take about 4-5 minutes, this creates a hard floor for total test run times.

Additionally, this means that any other test optimisations we do can never improve full test run times because InstallUninstallTest will still be running even if everything else was to be done in 10 minutes.

Any bugs this test might find in the future are outweighed by it adding 20-30% to test run times. Because it it is a 'hit and hope' test that is designed to test every possible module in sequence then all together, there is not really a way to split it up either - it would just duplicate other tests then.

Steps to reproduce

Proposed resolution

We have a lot more test coverage since this was added, and modules tend to do less on install than they used to, because a lot is handled by shipped config, so just delete the test. Move the hook help checking to help module which already has a test which install every core module.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

๐Ÿ“Œ Task
Status

Closed: duplicate

Version

11.0 ๐Ÿ”ฅ

Component
PHPUnitย  โ†’

Last updated about 5 hours ago

Created by

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024