Update PhpDoc type for Drupal\jsonapi\JsonApiResource\Link::$rel

Issue created by @bbrala
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
30,146 pass
@welly opened merge request.
Status changed to Needs review 10 months ago1:08pm 8 September 2023
Comment 10 months ago →
🇬🇧United Kingdom welly
I think this should be good!
Status changed to RTBC 10 months ago2:30pm 8 September 2023
Comment 10 months ago →
🇳🇱Netherlands bbrala Netherlands
Great thanks :)
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
30,144 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
30,148 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,154 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,161 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,164 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,168 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,205 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,205 pass

quietone → committed dff46835 on 11.x

Issue #3386058 by welly, bbrala: Update PhpDoc type for Drupal\jsonapi\...

Status changed to Fixed 9 months ago5:37am 26 September 2023
Comment 9 months ago →
🇳🇿New Zealand quietone New Zealand
For changes like this, that were fixed some time ago, it is useful to confirm that it truly has been fixed and in what issue.

The @todo was added in #3080259: Links with different target attributes are improperly merged → . Then #3080467: Remove BC layers from \Drupal\jsonapi\JsonApiResource\Link that handle links with more than one link relation type → was closed as a duplicate of #3092459: Remove jsonapi.module BC layers → . And that issue did change to using $rel as a string but did not update the class doc.

The closed issue is also not listed on 📌 [META] Fix @todo items referencing closed issues Active so that does not need to be updated.

Committed dff4683 and pushed to 11.x. Thanks!
Comment 9 months ago →
🇳🇱Netherlands bbrala Netherlands
Sorry quietone, will refer to the issue next time so you can verify that in the IS right away. Thank you for the guidance.
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Comments & Activities