drupal 10 version

Created on 7 September 2023, about 1 year ago
Updated 26 July 2024, 4 months ago

Thank you for the great efforts on the project, could you make it drupal 10 compatible๏ผŸMany thanks!

๐ŸŒฑ Plan
Status

Needs review

Version

2.0

Component

Code

Created by

๐Ÿ‡จ๐Ÿ‡ณChina marcolam

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @marcolam
  • Assigned to chetan 11
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia chetan 11

    @marcolam
    I have made this module compatible to drupal 10 version.
    Please check also attached the patch for this.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States philltran Detroit, MI

    @chetan 11 Thank you for submitting a patch. I will review it.

    @marcolam are you available to test?

  • ๐Ÿ‡จ๐Ÿ‡ณChina marcolam

    Getting this message:
    The next patch would delete the file urllogin.info,which does not exist!
    Should be urllogin.info.yml?

  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 year ago
    Patch Failed to Apply
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia chetan 11

    @marcolam
    We just need to use core_version_requirment: ^10 in urllogin.info.yml file.

  • ๐Ÿ‡จ๐Ÿ‡ณChina marcolam

    I got this error visiting /urllogin/userlist.csv

    Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of core/lib/Drupal/Core/Entity/Query/Sql/Query.php).

    env:2.x-dev, drupal 10.1,php 8.2

  • ๐Ÿ‡จ๐Ÿ‡ณChina marcolam

    I've set permission and still got 403 visiting l_test/qulTt0AGs7rW

    URL Login Status page:

    Test UID: 0
    Passphrase: Pass_phrase
    Current Validation number: 20110531 .
    Minimum validation number: 20110531 .
    Encoded URL access string: [qulTt0AGs7rW]

    the 2 validation number have been set to 20230911 and 20230910,seems not saved?

  • Status changed to Needs review 11 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dineshkumarbollu

    Hi @marcolam

    Created patch for D10 including the comment#8 issue, Please review, Thanks

  • ๐Ÿ‡จ๐Ÿ‡ณChina marcolam

    After applied patch #9 ,got this error visiting /urllogin/userlist.csv
    Error: Call to undefined function Drupal\urllogin\Controller\render() in Drupal\urllogin\Controller\UrlloginController->userList() (line 193 of modules/contrib/urllogin/src/Controller/UrlloginController.php).

    And #8 issue remains the same.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada jcornuz@gmail.com

    Replacing
    $response->setContent(render($output));

    with
    $response->setContent($output);

    on line 193 works for me.

Production build 0.71.5 2024