Confirming that this patch enabled me to download the config set while using a DDEV solr instance.
Changing status to "Needs work" as some deprecations discovered with drupal-check
------ ----------------------------------------------
Line field_image_style.module
------ ----------------------------------------------
32 Call to an undefined method
Drupal\Core\Form\FormInterface::getEntity().
------ ----------------------------------------------
------ --------------------------------------------------------------------------
Line src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php
------ --------------------------------------------------------------------------
140 Call to an undefined method
Drupal\Core\Entity\EntityInterface::getFileUri().
------ --------------------------------------------------------------------------I updated the patch to work on 2.0.x dev branch. I added a condition on gtag implementation of default consent to only apply if `gtm` is empty. Otherwise we would have consent.default set twice. I tested this successfully with GTM-xxx and AW-xxx ids. Using a G-xxx id made the consent.default load too late. I will continue to look into that issue and am open to anyone else's insight on the matter.
@zilloww Opps. My mistake. This patch moves the
if (config.consentMode === true) {
gtag('consent', 'default', {
ad_storage: 'denied',
analytics_storage: 'denied',
ad_user_data: 'denied',
ad_personalization: 'denied',
wait_for_update: 500,
});
}
code block from `/js/gtag.js` to `/js/gtm.js`
@zilloww Looks like this patch was committed via issue 3180185 ✨ Support Google Analytics consent mode Fixed
Here is a patch with the latest updates to the MR2.
philltran → made their first commit to this issue’s fork.
@chetan 11 Thank you for submitting a patch. I will review it.
@marcolam are you available to test?
@jamie.slater Your code worked for me too. I added a patch against the 8.x-1.1 tag as the 8.x-1.x branch was not up to date with the tag.
Reviewed the diff and the format looks good. Marking as RTBC. I see the "Requirements" section was removed. It does seem obvious that a Hotjar account is required.