- Issue created by @Jaypan
- Status changed to Needs review
10 months ago 4:01pm 6 September 2023 - last update
10 months ago 30,131 pass, 1 fail The last submitted patch, 2: drupal-incorrect_grammar_in_status_message_when_enabling_display_modes-3385666-2.patch, failed testing. View results →
- Status changed to Needs work
10 months ago 11:30pm 6 September 2023 - last update
10 months ago 30,136 pass - Status changed to Needs review
10 months ago 12:43am 7 September 2023 Hi @Jaypan, Agree with your statement.
I applied the #5 patch and it is cleanly applied, the status message is updated now - The [DISPLAY MODE] mode now uses custom display settings. You might want to configure it. Attached screenshot for reference.
Thanks- 🇮🇹Italy apaderno Brescia, 🇮🇹
Truly, in You might want to configure them. the subject is You, not The [DISPLAY MODE] mode.
them in that sentence would be the pronoun for custom display settings.I am not sure configure should be used for custom display settings. (I would rather say You might want to change them.) Either them is replaced by it (the display mode) or configure is replaced by another verb (for example, change).
- 🇨🇦Canada Jaypan
Do what you will, I've committed my patch. We can bikeshed the lingo for the next four years if we need to.
- Status changed to Needs work
10 months ago 9:50pm 8 September 2023 - 🇺🇸United States smustgrave
Brought up in #bugsmash and @mstrelan agreed with 8 and think that makes too.