Fix the issue reported by phpcs

$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml filter_by_type FILE: C:\xampp\htdocs\drupal-10.0.0\modules\contrib\filter_by_type\filter_by_type.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\drupal-10.0.0\modules\contrib\filter_by_type\README.md ---------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------- 15 | WARNING | Line exceeds 80 characters; contains 366 characters ---------------------------------------------------------------------------- FILE: C:\xampp\htdocs\drupal-10.0.0\modules\contrib\filter_by_type\src\BatchUpdateAuthor.php -------------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------------------- 44 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 45 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 83 | ERROR | [ ] Type hint "array" missing for $results 83 | ERROR | [ ] Type hint "array" missing for $operations 95 | ERROR | [x] Expected 1 blank line after function; 0 found 96 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\drupal-10.0.0\modules\contrib\filter_by_type\src\Form\TypeEditForm.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 5 WARNINGS AFFECTING 11 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 19 | WARNING | [x] Unused use statement 20 | WARNING | [x] Unused use statement 254 | ERROR | [ ] The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines 257 | ERROR | [ ] The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines 283 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 409 | WARNING | [ ] Node::load calls should be avoided in classes, use dependency injection instead 411 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 436 | ERROR | [ ] The array declaration extends to column 268 (the limit is 80). The array content should be split up over multiple lines 461 | ERROR | [x] Expected 1 space after IF keyword; 0 found 472 | ERROR | [x] Expected 1 blank line after function; 0 found 473 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- Time: 3.83 secs; Memory: 14MB

Comments & Activities

Issue created by @VijaySharma_89
Comment 10 months ago →
🇮🇳India sakthi_dev
Resolved the coding standard issues, please review.
Comment 10 months ago →
🇮🇳India chetan 11
chetan 11 → made their first commit to this issue’s fork.
@chetan-11 opened merge request.
Assigned to AditiVB
Comment 10 months ago →
🇮🇳India AditiVB
i will work on this
Issue was unassigned.
Comment 10 months ago →
🇮🇳India AditiVB
Status changed to Needs review 10 months ago11:19am 12 September 2023
Comment 10 months ago →
🇮🇳India arti_parmar
First commit to issue fork.
Comment 9 months ago →
🇵🇭Philippines clarkssquared
Hi

I applied the previous version of MR !1 and I noticed some phpcs issues and whitespace that are not yet fixed, I updated the MR to fix most of the issues, please review.

P.S. sorry for the multiple commits I did, will improve myself the next time time I will work on MR

Sincerely,
Clark
Comment 3 months ago →
🇮🇳India Preethy_ray
Hi,
Applied the MR!1, found no PHPCS errors and warnings.
Thank You!!

Fix the issue reported by phpcs

Problem/Motivation
Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml show the following errors/warnings, which should be fixed when they are not false positives.

Steps to reproduce
Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml filter_by_type

Comments & Activities

Fix the issue reported by phpcs

Problem/Motivation Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml show the following errors/warnings, which should be fixed when they are not false positives.

Steps to reproduce Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml filter_by_type

Comments & Activities

Problem/Motivation
Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml show the following errors/warnings, which should be fixed when they are not false positives.

Steps to reproduce
Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml filter_by_type