- Issue created by @luke.leber
- 🇺🇸United States luke.leber Pennsylvania
https://git.drupalcode.org/project/gin/-/blame/8.x-3.x/styles/base/_form... seems to be the critical difference between Gin and Claro in this regard.
Is PopperJS having some trouble when the inline
<label>
withposition: relative
? Changing theposition
property back to static seems to make things work with Gin -- but I'm assuming thatposition: relative
was intentionally set to create a new stacking context.Might want to pull Sascha in for a consultation here?
- 🇨🇭Switzerland saschaeggi Zurich
Pretty sure we added this on purpose for the
z-index: 1;
to work. So if we would want to removeposition: relative;
we would need to make sure we don't break labels. - Status changed to Needs review
over 1 year ago 3:12pm 13 September 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
Here is a quick fix to change the labels to not use relative positioning.
- 🇮🇳India kasli_harshit
HI @jrockowitz i have reviewed the Patch(#4) it is applied successfully now the tooltip message are rendering properly. Attaching the screenshot for the same. We can move this to RTBC+1.
Just to highlight : Before applying the patch in some of the cases the tooltip message in not even showing in the viewport. But working fine after the patch. - Status changed to Needs work
about 1 year ago 4:12pm 28 September 2023 - 🇺🇸United States luke.leber Pennsylvania
Hey Jacob,
It looks like there are some visual regressions from #4.
`position: static !important` is clobbering some styles applied by the
.visually-hidden
class. Under the Advanced tab, the Wrapper CSS classes field, select 'custom', and observe that with the patch, the visually hidden label on the attributes-class-other field is now visible, and scrunched up due to the other properties coming from.visually-hidden
This looks like it might be quite the pickle...hmm.
- Status changed to Fixed
9 months ago 3:06pm 7 April 2024 - 🇺🇸United States jrockowitz Brooklyn, NY
Yep, this is a game of whack-a-mole, but the approach from #6 is definitely an improvement. I am going to commit it.
- 6041c1af committed on 6.2.x
Issue #3384432: Tooltip incompatibility with Gin Admin Theme
- 6041c1af committed on 6.2.x
Automatically closed - issue fixed for 2 weeks with no activity.