This is a port of the work done in
🐛
hook_entity_extra_field_info() is called unnecessarily often, hurting performance
Fixed
.
This fortunately lands in Drupal Core 10.1.x and 11.x however as we're still in the midst of updating towards Drupal 10.0.x we have decided to backport this issue for Open Social and Drupal 9.5.x for the time being.
For any of the other details for this issue I recommend you to take a look at the issue over at 🐛 hook_entity_extra_field_info() is called unnecessarily often, hurting performance Fixed .
Copied from that issue summary:
Problem/Motivation
EntityFieldManager::getExtraFields()invokeshook_entity_extra_field_info()every time it is called with a different combination of entity type, bundle and language. In some real world use cases, it can amount to a large number of function calls and have a noticeable negative impact on performance.The problem is that
hook_entity_extra_field_info()collects and return extra field info about all entity types and bundles. Therefore it could be called only once per language, instead of being called once per entity type, bundle and language.Proposed resolution
Cache the result ofhook_entity_extra_field_info()the first timeEntityFieldManager::getExtraFields()is called, then reuse the cached data for subsequent calls.There is a balance to find between performance, permanent cache size increase and static cache size increase.
For some impact analysis check:
https://www.drupal.org/project/drupal/issues/3231503#comment-15130610
🐛
hook_entity_extra_field_info() is called unnecessarily often, hurting performance
Fixed
Fixed
11.10
Code (back-end)
Automatically closed - issue fixed for 2 weeks with no activity.