hook_entity_extra_field_info() is called unnecessarily often, hurting performance

I was suggesting earlier to make a constant for ['form' => [], 'display' => []].
But actually it would be pointless, there is nothing wrong with repeating a simple literal array like this.

We could go crazy with the ??= but I think people won't like it, so I don't :)

  public function getExtraFields($entity_type_id, $bundle) {
    return ($this->extraFields ??= $this->loadExtraFields())[$entity_type_id][$bundle] ?? [
      'form' => [],
      'display' => [],
    ];
  }

Is there a way to get a Blackfire or Xhprof profile of a before/after to see the improvements?

Is there a way to get a Blackfire or Xhprof profile of a before/after to see the improvements?

Even if we do, it is very project-specific.
It depends on the product of:
- Duration of discovering all extra fields, TIMES
- Number of entity bundles for which extra fields are requested.

On a project I am working on, that includes opensocial, the second factor was 171.
The MR would reduce this to 1.

More numbers later.

Steps to reproduce:

Preparation:

• Install Drupal with OpenSocial distro as in https://www.drupal.org/docs/drupal-distributions/open-social/installing-... → . Make it available at http://opensocial.localhost.
• Enable layout_builder module.

(If I just use core + layout_builder, I don't get enough significant difference)

Repeatable steps, thanks to https://stackoverflow.com/a/22625150/246724

time ./vendor/bin/drush cr; curl -w @- -o /dev/null -s "http://opensocial.localhost/" <<'EOF'                                  
    time_namelookup:  %{time_namelookup}\n
       time_connect:  %{time_connect}\n
    time_appconnect:  %{time_appconnect}\n
   time_pretransfer:  %{time_pretransfer}\n
      time_redirect:  %{time_redirect}\n
 time_starttransfer:  %{time_starttransfer}\n
                    ----------\n
         time_total:  %{time_total}\n
EOF

I get repeatedly:
Without the fix: time_total: ~6.7 seconds
With the fix: time_total: ~2.7 seconds

Why this scenario?

OpenSocial distro gives us a bunch of extra fields.

Layout builder gives us ExtraFieldBlockDeriver::getDerivativeDefinitions(), which requests all extra fields from all bundles at once.
Without this, the performance penalty would be distributed across different requests and harder to measure.

The original profiling I did with xdebug, but this is too much to post here.

Just for reference, on the original project I profiled, the cachegrind.out.* file without the fix was ~3.5GB, without it was more like 700MB.

The patches are no longer relevant, I would say.

Updating issue credits

Hiding patches

Let's go!

Appears all threads have been resolved so going to mark it

I second guessed this one due to the cache entry size potentially being much larger than the individual ones, but then convinced myself that's not a real problem - in general we're dealing with a handful at most of extra fields per entity type.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.