Change to use Config Translation for More label

Use the patch from https://www.drupal.org/project/smart_trim/issues/3391909#comment-15420167 🐛 Read more text not translatable Closed: duplicate .

I hope $this->t($more_settings['text']); from 🐛 Regression: More Labels No Longer Translated Fixed is not anymore part of code. Hello D7.

ATM you do not have a UI to translate Strings of formatter or field_groups etc, but when the schema say this part of configuration is translable (e. g. type label) , then you can create/update the config translation manually.

In the use case smart_trim is used as formatter in a view, the you have a UI to translate this part inside the translation form of the view.

🐛 Regression: More Labels No Longer Translated Fixed is only in dev-release.

Lets revert 🐛 Regression: More Labels No Longer Translated Fixed and use proper config schema.

This is still not really 100% sitebuilder friendly in field formatter use case, but for views, see screenshot.

I'm broadly in favour of this.

However, I think we need to find a solution to make the label translatable until 🐛 Entity view/form mode formatter/widget settings have no translation UI Needs review gets merged into core.

We need the schema changes anyway. Without this even a solution in 🐛 Entity view/form mode formatter/widget settings have no translation UI Needs review would not make the labels translable automatically or magic.

Agreed, but I believe updating the schema would be all that's needed if that core fix was in place.

I think that for now, we can:

1. Not change the $more = $this->t($more_settings['text']); in the formatter code, as ancient as it looks ;)
2. I'm fine with updating the config schema to use label.
3. Once 🐛 Entity view/form mode formatter/widget settings have no translation UI Needs review lands, then we update the formatter with branching code based on the core version (via \Drupal::VERSION) and remove the t() for versions >= whatever the version with the new code in (so we don't have to maintain two versions of the module).

I think this is a good compromise, all things considered.

-mike

I have changed the field type from "string" to "label" in the schema for the following fields:

• Trim suffix
• More link text
• More link Aria label

It would be nice to have a test for this, but until the core change is merged, I'm not sure if this is possible.

Looks good. Merged

The MR was not merged. ;-)

ohhh.. I'm supposed to press the "merge" button......

Automatically closed - issue fixed for 2 weeks with no activity.