- Issue created by @djsagar
- Status changed to Needs review
over 1 year ago 12:24pm 25 August 2023 - ๐ฎ๐ณIndia djsagar
Uploaded patch to resolve above issue kindly review.
Thanks!
- Status changed to RTBC
over 1 year ago 10:48am 28 August 2023 Verified the #2 patch on 9.5.8, the icons are removed from the left header when field value is empty. Added screenshots for reference, RTBC++
- ๐ฎ๐ณIndia soumya soni indore
@djsagar I applied this patch but it does not working , i got error when i applied patch.
- Status changed to Needs work
about 1 year ago 8:10am 28 September 2023 - Status changed to Needs review
about 1 year ago 11:50am 28 September 2023 - ๐ฎ๐ณIndia SandeepSingh199
Hi @soumya soni 3383369-2.patch โ is also not working for me, so I created a new patch, and also one issue noticed with the 3383369-2.patch. I fixed that issue in 3383369-6.patch.
- ๐ฎ๐ณIndia soumya soni indore
@SandeepSingh199 , This patch 3383369-6.patch is not working i attached screenshot so kindly review.
- ๐ฎ๐ณIndia SandeepSingh199
@soumya soni, Please follow the below steps :-
1. Take a clone of composer require 'drupal/harmony_haven:^1.0' inside themes/contrib.
2. move to harmony_haven folder (cd harmony_haven).
3. download the patch (wget https://www.drupal.org/files/issues/2023-09-28/3383369-6.patch โ ).
4. Finally apply the patch (git apply -v 3383369-6.patch).Please try again with above steps, hope this time patch will be applied.
- ๐ฎ๐ณIndia Gautam_105@
Gautam_105@ โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia Gautam_105@
soumya soni ,
i have fixed this issue and created MR for the same. Please review and see screenshot as well. - @gautam_105 opened merge request.
- Status changed to RTBC
about 1 year ago 6:12am 10 October 2023 - ๐ฎ๐ณIndia Sonal Gyanani
MR!5 has been successfully applied to the Drupal 9.5.x-dev, and it is functioning as expected.
Changes and Outcomes:
As a result of this merge:
The UI has been updated to remove the icon when no values are present in either the phone number or email fields.Attached screenshot for reference.
Thanks
- ๐ฎ๐ณIndia soumya soni indore
@SandeepSingh199,I again applied your 3383369-6.patch but its not working,Please review and see screenshot as well.
- Status changed to Fixed
about 1 year ago 11:40am 11 October 2023